Replace unmaintained bincode with postcard for asset serialization#3618
Open
Xavrir wants to merge 1 commit intosharkdp:masterfrom
Open
Replace unmaintained bincode with postcard for asset serialization#3618Xavrir wants to merge 1 commit intosharkdp:masterfrom
Xavrir wants to merge 1 commit intosharkdp:masterfrom
Conversation
Replace bincode (RUSTSEC-2025-0141) with postcard for serializing and deserializing syntax definitions, themes, and acknowledgements. bincode has been permanently abandoned by its maintainers. postcard is actively maintained, serde-compatible, and recommended by RustSec as a replacement. Closes sharkdp#3582
bafaa12 to
c114ae2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the unmaintained
bincodecrate withpostcardfor asset serialization, addressing RUSTSEC-2025-0141.Changes
bincode = "1.0"→postcard = { version = "1.0", features = ["alloc"] }postcard::from_bytes()instead ofbincode::deserialize_from()postcard::to_allocvec()instead ofbincode::serialize_into()assets/create.shWhy postcard?
Notes
bat cache --buildcaches from the old bincode format will need to rebuild (bat cache --build). The existingmetadata.yamlversion check will reject incompatible caches when the minor version bumps..binfiles (syntaxes, themes, acknowledgements) have been rebuilt using the new serialization format.Closes #3582