Replace path_abs dependency with std::path::absolute#3622
Open
Xavrir wants to merge 3 commits intosharkdp:masterfrom
Open
Replace path_abs dependency with std::path::absolute#3622Xavrir wants to merge 3 commits intosharkdp:masterfrom
Xavrir wants to merge 3 commits intosharkdp:masterfrom
Conversation
std::path::absolute() has been stable since Rust 1.79 and bat's MSRV is 1.88. This replaces path_abs (and its transitive dep std_prelude) with the standard library function, reducing the dependency count by 2. A lexical normalization step is applied after making the path absolute to match PathAbs::new() behavior of resolving . and .. components.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the
path_abscrate (and its transitive dependencystd_prelude) withstd::path::absolute(), which has been stable since Rust 1.79. Bat's MSRV is 1.88, so this is safe to use.A lexical normalization step is applied after
path::absolute()to matchPathAbs::new()behavior of stripping.and resolving..components, ensuring syntax mapping globs continue to match correctly.Changes
src/assets.rs: ReplacePathAbs::new(path)withabsolute_normalized(path)usingstd::path::absolute()+ component normalizationCargo.toml: Removepath_absdependencyCargo.lock: Updated (removespath_absandstd_prelude)Impact
path_abs,std_prelude)./..normalizationTesting
cargo test)syntax_detection_for_symlinked_filetest passes (verifies path absolutization still works correctly for syntax detection)