Add bound attribute to restrict derived impls #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcampbell0x2a
requested changes
Sep 2, 2023
Collaborator
wcampbell0x2a
left a comment
wcampbell0x2a
left a comment
There was a problem hiding this comment.
Could you add documentation to src/attributes.rs? Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analogous to serde's
This allows using generics without restricting them in the struct definition
The use-case for me is parsing into a raw form, then post-processing some fields, while retaining most of the structure. With this both can use the same generic type, and only the raw form needs to implement DekuRead/DekuWrite.
Inferring the bounds automatically would be better, but I'm not up to writing that right now.