Skip to content

Conversation

@Nub
Copy link

@Nub Nub commented May 19, 2024

This change is needed so parsers that work on stream data can know wether to advance into the buffer to find a valid message without having to manually search for magic bytes before feeding the DekuRead object.

…arsers for framing data from streams is easier
Copy link
Collaborator

@wcampbell0x2a wcampbell0x2a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Check the CI, there are some other errors.

@Nub
Copy link
Author

Nub commented May 19, 2024

Thanks! Check the CI, there are some other errors.

Will do! Shoulda marked this as a draft while I was working on that, apologies.

@Nub
Copy link
Author

Nub commented May 19, 2024

What version of the toolchain is being used, compiler outputs being used for tests without pinning a version is what's causing some of these CI failures. I had been on a nightly 1.80 which apparently changes the output of the compiler, fun fun!

@wcampbell0x2a
Copy link
Collaborator

What version of the toolchain is being used, compiler outputs being used for tests without pinning a version is what's causing some of these CI failures. I had been on a nightly 1.80 which apparently changes the output of the compiler, fun fun!

Yah I usually use nightly and then use cargo +stable test before commits. The toolchain used in CI is the stable one.

/// Parsing error when reading
Incomplete(NeedSize),
/// Failed to find magic
Framing(NeedMagic),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would prefer the name relate to magic, unless we plan on expanding this to be an enum with different variants

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants