fix: resolve test errors and deprecation warnings#731
Open
slowsage wants to merge 1 commit intosharkwouter:masterfrom
Open
fix: resolve test errors and deprecation warnings#731slowsage wants to merge 1 commit intosharkwouter:masterfrom
slowsage wants to merge 1 commit intosharkwouter:masterfrom
Conversation
- ERROR: Add pytest pythonpath config for test discovery - WARN: Replace deprecated locale.getdefaultlocale() with getlocale() - WARN: Use explicit 'is not None' for XML Element check - WARN: Move return statement out of finally block
Collaborator
|
Hey. Thanks for the PR and sorry for the delay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Installing minigalaxy-git on arch fails (
paru -S minigalaxy-git) with errors and warnings:Ran
python3 -m pytest -v -W errorto ensure no warnings remain.Note: Not super confident of locale related testing since I only have English.
Checklist