extensions: randr: Fix indices of rr-get-output-info and document its return values#199
Merged
dkochmanski merged 1 commit intosharplispers:masterfrom Jan 12, 2023
Conversation
Member
|
lgtm, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is equivalent to #172 without the type declaration and resulting conflicts, only fixing the return values of
rr-get-output-infoand adding some documentation.rr-get-ouput-infowas broken as detailed in #198 and #172. This fixes the issue by setting the correct index forcrtc-startand adjusting the code to retrieve the crtc sequence and name of the output.Also breaks some overlong lines and adds documentation for the return values.