Conversation
Contributor
mourningsickness
left a comment
There was a problem hiding this comment.
vscript.inc
line 9 - vaires -> varies
line 114 - it's -> its
line 317 - Return whenever if -> Return whether or not(?)
hehe
Collaborator
Author
typo fixes like that should go into the upstream vscript repo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: hasn't had a lot of testing in real scripts
Requirements (which are very incompatible with 64-bit):
Before vscript, checkpoints only saved these because maps couldn't do much:
(note the lack of player_speedmod disabled-buttons in there! I still need to add that TODO!)Since you can do a lot of funky stuff with vscript (and a mapper is already asking for vscript checkpoint support), these are the vscript/squirrel API I think should be enough.
And thank gosh I added
StringMap cp_cache_t::customdatafor this kind of thing a million years ago!TODO: