Enhance database compatibility for rankings and statistics#1252
Open
moemoequte wants to merge 2 commits intoshavitush:masterfrom
Open
Enhance database compatibility for rankings and statistics#1252moemoequte wants to merge 2 commits intoshavitush:masterfrom
moemoequte wants to merge 2 commits intoshavitush:masterfrom
Conversation
moemoequte
commented
Jul 13, 2025
moemoequte
commented
- Updated SQL queries in shavit-rankings.sp to support PostgreSQL and SQLite, including handling of INSERT and REPLACE statements.
- Modified shavit-stats.sp to adapt SQL syntax based on the database driver, ensuring compatibility for playtime updates and statistics retrieval.
- Adjusted shavit-wr.sp to format time values correctly across different database systems and refined leaderboard queries.
- Enhanced shavit-zones.sp to use INSERT ON CONFLICT for PostgreSQL, maintaining compatibility with MySQL and SQLite.
- Introduced a global driver variable to manage database-specific logic throughout the scripts.
- Updated SQL queries in shavit-rankings.sp to support PostgreSQL and SQLite, including handling of INSERT and REPLACE statements. - Modified shavit-stats.sp to adapt SQL syntax based on the database driver, ensuring compatibility for playtime updates and statistics retrieval. - Adjusted shavit-wr.sp to format time values correctly across different database systems and refined leaderboard queries. - Enhanced shavit-zones.sp to use INSERT ON CONFLICT for PostgreSQL, maintaining compatibility with MySQL and SQLite. - Introduced a global driver variable to manage database-specific logic throughout the scripts.
Contributor
|
hello! would you be able to help with postgre/sqlite in my PR? i'd like to make it fully compatible too, since you did all of this to fix other functionalities on those engines so presumably they would be more supported. #1255 c: |
Author
|
@mourningsickness Sure, I’d be happy to help! I’m a bit busy with work right now, but I can take a look over the weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.