Group zoned maps in LoadMapZones#1256
Merged
rtldg merged 2 commits intoshavitush:masterfrom Dec 31, 2025
Merged
Conversation
If a map had multiple end zones it would be in the map list multiple times. This fixes that issue
Contributor
|
it also improves the mapchooser to add a check for a start and end zone to catch maps with missing zones |
Contributor
Author
|
that would be good to do. not tonight though xd! |
Collaborator
|
I think I tested this a bit ago and had an issue. Probably with MariaDB or MySQL (5.7 @ nfoservers). Dunno. Would have to test / double-check |
Collaborator
|
Using GROUP BY like this has some issues on certain SQL engines so I switched it to SELECT DISTINCT.
I don't feel like writing more SQL to do that so I'll merge as-is for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a map had multiple end zones it would be in the map list multiple times. This fixes that issue.