Skip to content

feat(checkpoints): add shavit_checkpoints_always_save_replay_frames cvar #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akanora wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(checkpoints): add shavit_checkpoints_always_save_replay_frames cvar #1269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion addons/sourcemod/scripting/shavit-checkpoints.sp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ Convar gCV_RestoreStates = null;
Convar gCV_PersistData = null;
Convar gCV_MaxCP = null;
Convar gCV_MaxCP_Segmented = null;
Convar gCV_SaveReplayFrames = null;

Handle gH_CheckpointsCookie = null;

Expand Down Expand Up @@ -209,6 +210,7 @@ public void OnPluginStart()
gCV_MaxCP = new Convar("shavit_checkpoints_maxcp", "1000", "Maximum amount of checkpoints.\nNote: Very high values will result in high memory usage!", 0, true, 1.0, true, 10000.0);
gCV_MaxCP_Segmented = new Convar("shavit_checkpoints_maxcp_seg", "10", "Maximum amount of segmented checkpoints. Make this less or equal to shavit_checkpoints_maxcp.\nNote: Very high values will result in HUGE memory usage! Segmented checkpoints contain frame data!", 0, true, 1.0, true, 50.0);
gCV_PersistData = new Convar("shavit_checkpoints_persistdata", "600", "How long to persist timer data for disconnected users in seconds?\n-1 - Until map change\n0 - Disabled", 0, true, -1.0);
gCV_SaveReplayFrames = new Convar("shavit_checkpoints_always_save_replay_frames", "0", "If set to 1, practice checkpoints will always save replay frames.\nSet this to 1 to fix the shavit-myreplay !preview command for practice checkpoints.", FCVAR_NOTIFY, true, 0.0, true, 1.0);

Convar.AutoExecConfig();

Expand Down Expand Up @@ -1528,7 +1530,7 @@ bool SaveCheckpoint(int client, bool duplicate = false)

if (!duplicate)
{
SaveCheckpointCache(client, target, cpcache, index, INVALID_HANDLE);
SaveCheckpointCache(client, target, cpcache, index, INVALID_HANDLE, gCV_SaveReplayFrames.BoolValue);
gI_CurrentCheckpoint[client] = index;
}
else
Expand Down