Skip to content

Ensure app ready effect cleans up state #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shayancoin merged 2 commits into from
Oct 18, 2025
Merged

Ensure app ready effect cleans up state #147

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6188173
Ensure app ready effect cleans up state
shayancoin Oct 16, 2025
5ad9399
Merge branch 'main' into codex/update-cleanup-function-in-app-ready.tsx
shayancoin Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions frontend/src/app/components/app-ready.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ export function AppReadyEffect() {
if (frame !== null) {
cancelAnimationFrame(frame)
}

resetReady(appElement)
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Badge Fix resetReady invocation argument mismatch

resetReady is defined without parameters but the cleanup calls it as resetReady(appElement). With TypeScript's strict function arity checking this yields “Expected 0 arguments, but got 1” and the component fails to compile, preventing the build. Call the helper with no arguments or accept the element parameter.

Useful? React with 👍 / 👎.

}
}, [])

Expand Down
Loading