Skip to content

Restore navigation-duration metric IDs in perf budget journeys#420

Merged
shayancoin merged 1 commit intomainfrom
codex/update-journey-metrics-in-perf-budget.yml
Oct 18, 2025
Merged

Restore navigation-duration metric IDs in perf budget journeys#420
shayancoin merged 1 commit intomainfrom
codex/update-journey-metrics-in-perf-budget.yml

Conversation

@shayancoin
Copy link
Owner

@shayancoin shayancoin commented Oct 18, 2025

Summary

  • convert the performance budget configuration to the current pages schema
  • add a journeys entry and set navigation metrics back to the navigation-duration identifier

Testing

  • npm run perf:budget (fails: connection refused because http://localhost:3000 is not running in the container)

https://chatgpt.com/codex/tasks/task_e_68f40d7539308330b2c7bfe3711363b8

Summary by CodeRabbit

Release Notes

  • Chores
    • Reorganized performance monitoring configuration structure for improved clarity
    • Introduced new journey tracking to monitor multi-page user flows
    • Updated performance metric thresholds and added new performance metrics (total blocking time, cumulative layout shift) for enhanced monitoring

@shayancoin shayancoin merged commit f2b8381 into main Oct 18, 2025
0 of 4 checks passed
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 18, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The perf-budget.yml configuration file undergoes schema restructuring, replacing the "scenarios" section with "pages", updating page structure from step-based to URL-based with consolidated waits, removing selector definitions, and introducing a new top-level "journeys" section for multi-page performance tracking.

Changes

Cohort / File(s) Summary
Performance budget configuration
perf-budget.yml
Renames top-level scenarios to pages; updates page structure from step-based (steps, goto, selectors) to direct (url, waits); removes per-page selector definitions (generate_button, price_total); adjusts metrics thresholds for configurator-load page (first-contentful-paint: 2000 ms, largest-contentful-paint: 3500 ms); adds new metrics (total-blocking-time, cumulative-layout-shift); introduces new journeys section with homepage-to-configurator journey containing from_url, to_url, waits, and metrics; migrates existing journey from old to new structure without interactions or post-interaction waits.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

The changes are consistent structural transformations of a configuration file with well-defined schema alterations. Review should verify that all metrics thresholds are correctly updated and that the schema properly aligns with consuming code (tests, workflows).

Possibly related PRs

Poem

🐰 Scenarios → Pages, a grand refactor so fine,
Journeys now sparkle like carrots in line,
Waits consolidated, metrics aligned,
A structure reborn, performance redesigned! ✨

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch codex/update-journey-metrics-in-perf-budget.yml

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8b1258e and 8e463ed.

📒 Files selected for processing (1)
  • perf-budget.yml (2 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant