Restore navigation-duration metric IDs in perf budget journeys#420
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThe perf-budget.yml configuration file undergoes schema restructuring, replacing the "scenarios" section with "pages", updating page structure from step-based to URL-based with consolidated waits, removing selector definitions, and introducing a new top-level "journeys" section for multi-page performance tracking. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes The changes are consistent structural transformations of a configuration file with well-defined schema alterations. Review should verify that all metrics thresholds are correctly updated and that the schema properly aligns with consuming code (tests, workflows). Possibly related PRs
Poem
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
Comment |
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68f40d7539308330b2c7bfe3711363b8
Summary by CodeRabbit
Release Notes