Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
|
Warning Rate limit exceeded@shayancoin has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 39 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (3)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
|
Caution Docstrings generation - FAILED No docstrings were generated. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Mount routers | ||
| router.include_router(shopify_router) | ||
| router.include_router(exports_router) |
There was a problem hiding this comment.
Avoid registering exports router twice with different prefixes
exports_router is included on the aggregate API router and again on the FastAPI app, even though it already wraps routes_cnc (whose path prefix is /api/cnc). The inclusion in backend/api/routes.py adds another /api prefix, so the same endpoint tree is mounted a second time at /api/api/cnc, which causes FastAPI’s schema generation to blow up with AttributeError: 'property' object has no attribute 'schema' and leaves duplicate paths exposed. Register the router in only one place or adjust prefixes so each export route is added once.
Useful? React with 👍 / 👎.
Summary
Testing
poetry run pytest tests/test_routes_quote_cnc.py(fails: AttributeError: 'property' object has no attribute 'schema')https://chatgpt.com/codex/tasks/task_e_68f72bf9d4448330bd680c8f95d004fc