Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... 📒 Files selected for processing (18)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
|
Note Docstrings generation - SUCCESS |
Docstrings generation was requested by @shayancoin. * #551 (comment) The following files were modified: * `frontend/src/app/configurator/quote/complete/page.tsx` * `frontend/src/app/dealer/actions.ts` * `frontend/src/app/kitchen-configurator/[sku]/page.tsx` * `frontend/src/app/server-actions/dealerQuotes.ts` * `frontend/src/app/web-vitals.ts` * `frontend/src/lib/auth.ts` * `frontend/tests/e2e/perf/perf-budget-loader.ts` * `frontend/tests/e2e/utils/wasm-decoder-polyfill.ts`
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| from backend.services.storage import StorageClient, StoredObject | ||
| from services.cnc_service import CNCService | ||
| from backend.services.cnc_service import CNCService |
There was a problem hiding this comment.
The new import from backend.services.cnc_service import CNCService assumes the project root is on PYTHONPATH so backend is a package. The backend Dockerfile (and most local runs) execute uvicorn api.main:app with the working directory set to backend/, where only modules like api and services are importable. Under that setup the process raises ModuleNotFoundError: No module named 'backend' at startup, preventing any API routes—including the docs OpenAPI generation—from loading. The previous relative import from services.cnc_service import CNCService worked regardless of working directory. Revert to a relative import or adjust the runtime path so the server can start.
Useful? React with 👍 / 👎.
…n` (#554) Docstrings generation was requested by @shayancoin. * #551 (comment) The following files were modified: * `frontend/src/app/configurator/quote/complete/page.tsx` * `frontend/src/app/dealer/actions.ts` * `frontend/src/app/kitchen-configurator/[sku]/page.tsx` * `frontend/src/app/server-actions/dealerQuotes.ts` * `frontend/src/app/web-vitals.ts` * `frontend/src/lib/auth.ts` * `frontend/tests/e2e/perf/perf-budget-loader.ts` * `frontend/tests/e2e/utils/wasm-decoder-polyfill.ts` Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68f859a299c48330b9233c6990da9e6b
Summary by CodeRabbit
Release Notes
New Features
Improvements