test: add gallery affordances, vrt tests, and perf budgets#618
test: add gallery affordances, vrt tests, and perf budgets#618shayancoin merged 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Rate limit exceeded@shayancoin has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 23 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (3)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
|
Caution Docstrings generation - FAILED No docstrings were generated. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| test('gallery affordances reveal on hover', async ({ page }) => { | ||
| await page.goto(CONFIGURATOR_URL); | ||
| const gallery = page.locator('.kds-gallery-frame'); | ||
| await gallery.hover(); | ||
| const controls = page.locator('.kds-gallery__ctrl'); | ||
| await expect(controls).toHaveCount(2); |
There was a problem hiding this comment.
The hover test asserts that two .kds-gallery__ctrl elements become visible, but the configurator page renders only spans inside .kds-gallery-affordances (ClientPage.tsx lines 20‑27) and no elements with a kds-gallery__* class exist anywhere in the codebase. Consequently page.locator('.kds-gallery__ctrl') always matches zero nodes and the test will fail before verifying anything about the affordances. Update the test (or the markup) so the selectors correspond to actual DOM nodes.
Useful? React with 👍 / 👎.
1 participant
PR Type
[Feature | Fix | Documentation | Other() ]
Short Description
...
Tests Added
...