Fix [[A; N]; M] cannot be used with allo isolate#66
Closed
fzyzcjy wants to merge 2 commits intoshekohex:masterfrom
Closed
Fix [[A; N]; M] cannot be used with allo isolate#66fzyzcjy wants to merge 2 commits intoshekohex:masterfrom
[[A; N]; M] cannot be used with allo isolate#66fzyzcjy wants to merge 2 commits intoshekohex:masterfrom
Conversation
[[A; 3]; 3] cannot be used with allo isolate[[A; N]; M] cannot be used with allo isolate
shekohex
requested changes
May 16, 2025
Owner
shekohex
left a comment
There was a problem hiding this comment.
Looks good to me, do you mind fixing the CI?
Contributor
Author
|
Well I have no time recently :( |
Owner
There is also a memory leak that the CI has detected after this change. |
Contributor
Author
|
Hmm, wondering whether it is a real leak or not. Looks like it is caused by random_seed. Maybe we should suppress it? |
Owner
Yes! |
Owner
|
any followup on this PR @fzyzcjy so we can complete it? |
Contributor
Author
|
Since there seems to be no real errors I may not have time to further update it :( |
Owner
See #70 |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix fzyzcjy/flutter_rust_bridge#2703