fix: incorrect p3 chunk range printed in overlapping_chunks#209
Merged
Kyle-Kyle merged 1 commit intoshellphish:masterfrom May 26, 2025
hx294:fix-print-error
Merged
fix: incorrect p3 chunk range printed in overlapping_chunks#209Kyle-Kyle merged 1 commit intoshellphish:masterfrom hx294:fix-print-error
Kyle-Kyle merged 1 commit intoshellphish:masterfrom
hx294:fix-print-error
Conversation
Contributor
|
thanks for pointing it out! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed incorrect printed size range of chunk p3.
Previously it printed
p3as ending atp3 + 0x580 - 8, which corresponds to the size of p2/p4.Corrected it to
p3 + 0x80 - 8to match the actual malloc size.This helps avoid confusion when analyzing the chunk overlap behavior.