-
-
Notifications
You must be signed in to change notification settings - Fork 186
feat!: ESM only, Node 20+ #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+2,369
−2,418
Merged
Changes from 3 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
0f3149b
feat!: ESM only, Node 20+\n\n- Migrate package to ESM-only (type: mod…
CharlieHelps 48c5736
chore(ci): add eslint devDependency so `pnpm lint:js` works in CI
CharlieHelps 6e65ef9
chore(eslint): configure NodeNext TS resolver; drop inline suppressions
CharlieHelps 090e7e7
ci(workflows): avoid duplicate runs on PR pushes; bump actions; move …
CharlieHelps 9c89e00
chore(eslint): configure NodeNext resolver; test(ts): allow TS extens…
CharlieHelps 6471bf5
Resolve rebase conflicts for ESLint resolver settings and lockfile (e…
CharlieHelps 9f216c5
chore(eslint): configure TypeScript resolver for NodeNext; remove inl…
CharlieHelps 8d596f8
chore(eslint): broaden node resolver extensions for ESM/CJS/TS varian…
CharlieHelps 806f66e
fix: resolve rebase conflicts\n\n- Finalize ESLint resolver settings …
CharlieHelps b49c290
chore(eslint): include root JS configs in tsconfig.eslint.json (./*.{…
CharlieHelps 4fe57bb
chore(lint): expand lint-staged to include TS; dedupe eslint --cache …
CharlieHelps d29f344
test(integration): save watcher handle to close in teardown; fix lint…
CharlieHelps 4a9d850
docs(readme): remove CJS dynamic import note per Node 20.19.0 review
CharlieHelps File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| module.exports = { | ||
| extends: ["shellscape/typescript"], | ||
| parserOptions: { | ||
| project: ["./tsconfig.eslint.json"], | ||
| tsconfigRootDir: __dirname, | ||
| }, | ||
| settings: { | ||
| // Resolve ESM-style .js specifiers to TypeScript source under NodeNext | ||
| 'import/resolver': { | ||
| typescript: { | ||
| project: './tsconfig.eslint.json' | ||
| }, | ||
| node: { | ||
| extensions: ['.js', '.ts', '.d.ts'] | ||
| } | ||
| } | ||
| } | ||
| }; |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,7 +16,7 @@ jobs: | |
|
|
||
| strategy: | ||
| matrix: | ||
| node: ['18'] | ||
| node: ['20.19.0'] | ||
|
|
||
| name: Node v${{ matrix.node }} | ||
| steps: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 18 | ||
| 20.19.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| module.exports = require('eslint-config-shellscape/prettier'); |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| module.exports = { extends: ['@commitlint/config-conventional'] }; |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CharlieHelps As of Node 20.19.0 this is not a correct statement. Remove this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the incorrect sentence from README per your note.
What changed
README.md, dropped the line: “The package is ESM-only. If your project uses CommonJS, migrate to ESM or load this plugin from a dynamic import().”Re-requested review from @CharlieHelps and @shellscape.