refactor(dataclass): remove pyright ignores by using parameterized generic aliases as field factories#5
Merged
shenxiangzhuang merged 3 commits intomasterfrom Mar 10, 2026
Conversation
…eld factories Co-authored-by: shenxiangzhuang <17157965+shenxiangzhuang@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor code and design framework for improvements
refactor(kagent): replace unnecessary lambda wrappers in dataclass field factories
Mar 10, 2026
…enerics, removing pyright ignores Co-authored-by: shenxiangzhuang <17157965+shenxiangzhuang@users.noreply.github.com>
Copilot
AI
changed the title
refactor(kagent): replace unnecessary lambda wrappers in dataclass field factories
refactor(dataclass): remove pyright ignores by using parameterized generic aliases as field factories
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
field(default_factory=list)causes Pyright strict mode to inferlist[Unknown]regardless of the field's type annotation, requiring# pyright: ignore[reportUnknownVariableType]suppressions. Using the parameterized formlist[T]/dict[K, V]as the factory gives Pyright the exact return type it needs.Changes
list/dictfactories with their parameterized equivalents and removed all associated ignore comments:kagent/state.pytools: list[Tool]list[Tool]kagent/trace/entry.pydata: dict[str, Any]dict[str, Any]kcastle/providers/config.pyoptions: dict[str, object]×2dict[str, object]kcastle/providers/config.pymodels: list[ModelConfig]list[ModelConfig]kcastle/config.pyoptions: dict[str, object]dict[str, object]kcastle/config.pyproviders: dict[str, ProviderEntry]dict[str, ProviderEntry]kcastle/skills/skill.pytags: list[str]list[str]The remaining
# pyright: ignore[reportUnknownVariableType]comments in the codebase (on dict-iteration over untyped YAML data) are a separate, unrelated issue and are not touched here.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.