refactor(kcastle): apply Single Responsibility Principle to Skill, SkillManager, and Castle#6
Merged
shenxiangzhuang merged 2 commits intomasterfrom Mar 10, 2026
Conversation
Co-authored-by: shenxiangzhuang <17157965+shenxiangzhuang@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor class design for Single Responsibility Principle
refactor(kcastle): apply Single Responsibility Principle to Skill, SkillManager, and Castle
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three classes carried responsibilities beyond their core concerns, violating SRP. This refactor extracts those responsibilities into dedicated owners.
Skill— rendering and parsing extracted to module-level functionsSkillwas a data/persistence class that also owned prompt rendering and hint parsing. Removed three static methods; replaced with module-level functions exported fromkcastle.skills:SkillManager— gainsexpand_hints()Skill hint expansion (parse hints → look up skills → render bodies) is a skill-management concern. Moved the logic from
Castle.prepare_user_input()intoSkillManager.expand_hints(user_input).Castle.prepare_user_input()is now a one-line delegate.New
ModelManager— LLM model management extracted fromCastleCastlemixed lifecycle orchestration with per-session provider/model state. Extracted intokcastle/providers/model_manager.py:get_active_model(session_id)— session override lookup with persistence restorationswitch_model(provider_name, model_id, *, session_id)— runtime model switchingavailable_models()— enumerate all configured active modelsbuild_provider(provider_name, model_id)— validated provider constructionCastlestores aModelManagerinstance and exposes thin delegation wrappers to preserve the existing public API.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.