Skip to content

chore(py): start from 3.12 #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shenxiangzhuang merged 1 commit into from
Dec 18, 2025
Merged

chore(py): start from 3.12 #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build_docs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
strategy:
matrix:
python-version:
- "3.13"
- "3.12"
Copy link

@coderabbitai coderabbitai bot Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Critical: Documentation deployment will fail due to matrix mismatch.

The docs build matrix only includes Python 3.12, but the deploy condition on line 49 checks for Python 3.13. This mismatch means documentation will never be deployed because no job will satisfy the deployment condition.

🔎 Apply this diff to fix the deploy condition:

Update line 49 to match the matrix version:

-      - name: Deploy docs
-        if: matrix.os == 'ubuntu-latest' && matrix.python-version == '3.13' && github.event_name == 'push' && github.ref == 'refs/heads/master'
-        run: uv run mkdocs gh-deploy --force
+      - name: Deploy docs
+        if: matrix.os == 'ubuntu-latest' && matrix.python-version == '3.12' && github.event_name == 'push' && github.ref == 'refs/heads/master'
+        run: uv run mkdocs gh-deploy --force

Alternatively, if you want to keep deploying with Python 3.13, add it to the matrix on line 15.

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents 
.github/workflows/build_docs.yaml around line 15 (and adjust line 49): the build
matrix currently lists only Python "3.12" but the deploy condition checks for
"3.13", causing docs never to deploy; fix by making the matrix and deploy
condition match—either change the deploy condition at line 49 to "3.12" or add
"3.13" to the matrix on line 15 so the checked-for version exists; ensure both
the matrix entries and the if/deploy condition use the exact same version
string.

os:
- ubuntu-latest
- macos-latest
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["3.10", "3.11", "3.12", "3.13"]
python-version: ["3.12", "3.13", "3.14"]
os: [ubuntu-latest, macos-latest, windows-latest]
runs-on: ${{ matrix.os }}
steps:
Expand Down
9 changes: 4 additions & 5 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,11 @@ classifiers = [
"Intended Audience :: Science/Research",
"Intended Audience :: Developers",
"Operating System :: OS Independent",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
"Programming Language :: Python :: 3.14",
]
requires-python = ">= 3.10"
requires-python = ">= 3.12"
dependencies = []

[project.optional-dependencies]
Expand Down Expand Up @@ -105,8 +104,8 @@ exclude = [
line-length = 120
indent-width = 4

# Assume Python 3.10
target-version = "py310"
# Assume Python 3.12
target-version = "py312"

[tool.ruff.lint]
select = [
Expand Down
Loading