Skip to content

chore: update publish workflow to remove caching#204

Merged
shenxiangzhuang merged 1 commit intomasterfrom
shenxiangzhuang-patch-1
Dec 19, 2025
Merged

chore: update publish workflow to remove caching#204
shenxiangzhuang merged 1 commit intomasterfrom
shenxiangzhuang-patch-1

Conversation

@shenxiangzhuang
Copy link
Owner

@shenxiangzhuang shenxiangzhuang commented Dec 19, 2025

Removed caching for dependencies in the Python publish workflow and adjusted the install command.

Summary by CodeRabbit

  • Chores
    • Updated Python package publishing workflow configuration.

✏️ Tip: You can customize this high-level summary in your review settings.

Removed caching for dependencies in the Python publish workflow and adjusted the install command.

Signed-off-by: Mathew Shen <datahonor@gmail.com>
@coderabbitai
Copy link

coderabbitai bot commented Dec 19, 2025

Walkthrough

This PR modifies the Python publish CI workflow by removing caching configuration from the setup-uv action and replacing the --dev flag with --all-extras in the uv sync command, altering dependency installation strategy.

Changes

Cohort / File(s) Summary
CI/CD Workflow Configuration
\.github/workflows/python-publish\.yml
Removed caching settings (enable-cache, cache-dependency-glob) from setup-uv action; replaced uv sync --dev with uv sync --all-extras

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single workflow file with straightforward configuration adjustments
  • No complex logic or multi-component interactions to verify
  • Changes are self-documenting removal/replacement operations

Possibly related PRs

  • PR #168 in shenxiangzhuang/mppt — Also modifies .github/workflows/python-publish.yml with uv installation/cache configuration adjustments, addressing similar CI setup concerns.

Poem

🐰 No cache, just extras—hooray!
The workflow runs a different way,
All features now, no dev subset,
A simpler sync, no regrets yet! 🎉

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: update publish workflow to remove caching' accurately reflects the main change: removing caching configuration from the Python publish workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch shenxiangzhuang-patch-1

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8cf42fa and bff5845.

📒 Files selected for processing (1)
  • .github/workflows/python-publish.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: ci (3.14, macos-latest)
🔇 Additional comments (2)
.github/workflows/python-publish.yml (2)

20-20: LGTM: Caching removal is reasonable for infrequent workflows.

Removing dependency caching is acceptable for a publish workflow that only runs on releases. The performance impact is minimal given the infrequent execution.


27-27: uv sync --all-extras doesn't install dev dependencies for this project.

The project has no optional dependencies (extras), only dev and docs groups. Changing from uv sync --dev to uv sync --all-extras removes dev dependency installation. However, uv build will still work since it automatically uses the build backend specified in [build-system] (setuptools >= 61.0), which is independent of the project environment. For a publish-only workflow, this may be acceptable, but verify that no dev tools are needed in this CI step.

Likely an incorrect or invalid review comment.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (8cf42fa) to head (bff5845).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #204   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines            8         8           
=========================================
  Hits             8         8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shenxiangzhuang shenxiangzhuang merged commit 7d80cc0 into master Dec 19, 2025
16 checks passed
@shenxiangzhuang shenxiangzhuang deleted the shenxiangzhuang-patch-1 branch December 19, 2025 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant