-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Fix dailykos F+ #2580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix dailykos F+ #2580
Conversation
Automatic validation of changes
|
Good catch. One of the downfalls of message checks. Are you in an allowed region or a blocked one? Could be useful in validating alternatives to eliminate it by the 403, as well. |
Sir , I'm in a blocked region (testing from India/Asia) , while testing endpoint got , Probe URL also returns 403 with geo-block message |
plz take the further actions |
It hasn't even been 24hr since my last comment, people have jobs |
Sorry sir , if i have offended u ... |
No worries, things just take time Could you
Attempting an alternative resolution for this issue that may help with other sites as well. If this works, I'll be reverting the dailykos change in that PR so you can make the site change yourself with the new feature (and get credit for hacktoberfest). |
Successfully tested the feat/multiple-types branch! Command executed: poetry run sherlock --site dailykos uirgheerig blue --local --print-all [-] dailykos: Not Found! [*] Checking username blue on: [-] dailykos: Not Found! [*] Search completed with 0 results |
could this get a pr? |
Merged #2597 into master (without dailykos). If you could Once you make the change and commit, you can overwrite the branch on this PR by |
- Updated dailykos errorType to ["message", "status_code"] - This leverages the new multiple-types feature to handle both message-based detection and 403 status codes from CloudFront geo-restrictions - Resolves false positives in blocked regions while maintaining accurate username detection
(some of the automatic tests here will probably fail, that is expected with this change ---- no worries) |
afa01f8
to
699ef42
Compare
Automatic validation of changes
Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences). |
Huh. They all worked. Even better. Anyways, LGTM! Merging into master now |
ok sir , i have done the changes , as told |
Hm. Actually... minor hold up. This will likely break existing installations. We should push a new version before merging this. Tagging this as accepted though so it's counted by hacktoberfest while pending that change. |
Thank You sir for guiding me , looking forward to seeing this in v0.17.0 and thank you for marking it as hacktoberfest-accepted |
dailykos uses CloudFront geo-restrictions that return 403 errors for blocked regions, causing false positives in username detection. Added comment to document this known issue.