Skip to content

Conversation

dollaransh17
Copy link
Contributor

dailykos uses CloudFront geo-restrictions that return 403 errors for blocked regions, causing false positives in username detection. Added comment to document this known issue.

Copy link
Contributor

github-actions bot commented Oct 3, 2025

Automatic validation of changes

Target F+ Check F- Check
dailykos ✔️   Pass ✔️   Pass

@ppfeister
Copy link
Member

Good catch. One of the downfalls of message checks.

Are you in an allowed region or a blocked one? Could be useful in validating alternatives to eliminate it by the 403, as well.

@dollaransh17
Copy link
Contributor Author

dollaransh17 commented Oct 3, 2025

Good catch. One of the downfalls of message checks.

Are you in an allowed region or a blocked one? Could be useful in validating alternatives to eliminate it by the 403, as well.

Sir , I'm in a blocked region (testing from India/Asia) , while testing endpoint got , Probe URL also returns 403 with geo-block message
curl -k "https://www.dailykos.com/signup/check_nickname?nickname=testuser"
Returns: "The Amazon CloudFront distribution is configured to block access from your country"

@dollaransh17
Copy link
Contributor Author

plz take the further actions

@ppfeister
Copy link
Member

It hasn't even been 24hr since my last comment, people have jobs

@dollaransh17
Copy link
Contributor Author

It hasn't even been 24hr since my last comment, people have jobs

Sorry sir , if i have offended u ...

@ppfeister
Copy link
Member

ppfeister commented Oct 4, 2025

No worries, things just take time

Could you checkout the feat/multiple-types branch found in #2597 and try this command?

poetry run sherlock --site dailykos uirgheerig blue --local --print-all

Attempting an alternative resolution for this issue that may help with other sites as well. If this works, I'll be reverting the dailykos change in that PR so you can make the site change yourself with the new feature (and get credit for hacktoberfest).

@dollaransh17
Copy link
Contributor Author

No worries, things just take time

Could you checkout the feat/multiple-types branch found in #2597 and try this command?

poetry run sherlock --site dailykos uirgheerig blue --local --print-all

Attempting an alternative resolution for this issue that may help with other sites as well. If this works, I'll be reverting the dailykos change in that PR so you can make the site change yourself with the new feature (and get credit for hacktoberfest).

Successfully tested the feat/multiple-types branch!

Command executed: poetry run sherlock --site dailykos uirgheerig blue --local --print-all
Output:
[*] Checking username uirgheerig on:

[-] dailykos: Not Found!

[*] Checking username blue on:

[-] dailykos: Not Found!

[*] Search completed with 0 results
So , sir the alternative solution works perfectly . No 403 geo-restriction errors from my blocked region (India). Both test usernames correctly returned "Not Found!" instead of false positives.

@dollaransh17
Copy link
Contributor Author

could this get a pr?

@ppfeister
Copy link
Member

Merged #2597 into master (without dailykos).

If you could git reset --hard 1d2c4b134f8125c4fdacc3d7cc107ec442832f33 and then simply change the errorType to "errorType": ["message", "status_code"] instead of "errorType": "message", that should be good!

Once you make the change and commit, you can overwrite the branch on this PR by git push --force-with-lease

- Updated dailykos errorType to ["message", "status_code"]
- This leverages the new multiple-types feature to handle both message-based detection and 403 status codes from CloudFront geo-restrictions
- Resolves false positives in blocked regions while maintaining accurate username detection
@ppfeister
Copy link
Member

ppfeister commented Oct 4, 2025

(some of the automatic tests here will probably fail, that is expected with this change ---- no worries)

@dollaransh17 dollaransh17 force-pushed the fix/dailykos-geo-restrictions branch from afa01f8 to 699ef42 Compare October 4, 2025 21:28
Copy link
Contributor

github-actions bot commented Oct 4, 2025

Automatic validation of changes

Target F+ Check F- Check
Roblox ❌   Fail ✔️   Pass
dailykos ✔️   Pass ✔️   Pass
SlideShare ❌   Fail ✔️   Pass
threads ❌   Fail ✔️   Pass
CyberDefenders ✔️   Pass ✔️   Pass

Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences).

@ppfeister
Copy link
Member

Huh. They all worked. Even better.

Anyways, LGTM! Merging into master now

@dollaransh17
Copy link
Contributor Author

(some of the automatic tests here will probably fail, that is expected with this change ---- no worries)

ok sir , i have done the changes , as told

@ppfeister
Copy link
Member

Hm. Actually... minor hold up.

This will likely break existing installations. We should push a new version before merging this.
Let me make a few changes and we'll be pushing 0.17.0 or 0.16.1 shortly. This will be merged alongside.

Tagging this as accepted though so it's counted by hacktoberfest while pending that change.

@ppfeister ppfeister self-assigned this Oct 4, 2025
@ppfeister ppfeister added hacktoberfest-accepted staged - do not merge PR is staged for coordinated release labels Oct 4, 2025
@ppfeister ppfeister added this to the v0.17.0 milestone Oct 4, 2025
@dollaransh17
Copy link
Contributor Author

Hm. Actually... minor hold up.

This will likely break existing installations. We should push a new version before merging this. Let me make a few changes and we'll be pushing 0.17.0 or 0.16.1 shortly. This will be merged alongside.

Tagging this as accepted though so it's counted by hacktoberfest while pending that change.

Thank You sir for guiding me , looking forward to seeing this in v0.17.0 and thank you for marking it as hacktoberfest-accepted

@ppfeister ppfeister changed the title Add geo-restriction warning for dailykos Fix dailykos F+ Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted staged - do not merge PR is staged for coordinated release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants