Skip to content

feat: Implement site name aliases #2581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: Implement site name aliases #2581

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5b38e94
A
shreyasNaik0101 Oct 3, 2025
91ba5a4
feat: Implement working site alias logic
shreyasNaik0101 Oct 6, 2025
cc298d1
style: Revert indentation to 2 spaces
shreyasNaik0101 Oct 6, 2025
818cab7
fix: Remove duplicate code block
shreyasNaik0101 Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion sherlock_project/resources/data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2268,7 +2268,6 @@
"regexCheck": "^[a-zA-Z0-9_]{1,15}$",
"url": "https://x.com/{}",
"urlMain": "https://x.com/",
"urlProbe": "https://nitter.privacydev.net/{}",
"username_claimed": "blue"
},
"Typeracer": {
Expand Down
6 changes: 5 additions & 1 deletion sherlock_project/sherlock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -783,7 +783,11 @@ def main():
# Eventually, the rest of the code will be updated to use the new object
# directly, but this will glue the two pieces together.
site_data_all = {site.name: site.information for site in sites}
if not args.site_list:
# Create original dictionary from SitesInformation() object.
# Eventually, the rest of the code will be updated to use the new object
# directly, but this will glue the two pieces together.
site_data_all = {site.name: site.information for site in sites}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On lines 786-789:

@shreyasNaik0101 Small cleanup needed - this line appears to be a duplicate of line 786. Can you remove the duplicate?

site_data_all = {site.name: site.information for site in sites}	
# Create original dictionary from SitesInformation() object.		← Duplicate
# Eventually, the rest of the code will be updated to use the new object 		← Duplicate
# directly, but this will glue the two pieces together.		← Duplicate
site_data_all = {site.name: site.information for site in sites}	# ← Duplicate

One of these should be removed. Thanks!

if args.site_list == []:
# Not desired to look at a sub-set of sites
site_data = site_data_all
else:
Expand Down
Loading