-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Add proxy URL validation with regex check #2594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add proxy URL validation with regex check #2594
Conversation
Hi! This PR adds proxy URL validation with regex check to improve user experience and resolve a TODO comment. Could a maintainer please approve the workflow run? Thank you! 🙏 |
Hi @ppfeister , just following up on this PR. The merge conflicts have been resolved and the branch is now clean. Could you please review or approve the workflow when you get a chance? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(sherlock-project-py3.13) ➜ sherlock git:(refactor/remove-global-variable-notify) sherlock --site blogger uihregiuh
https://github.com/sherlock-project/sherlock/releases/tag/v0.16.0
Traceback (most recent call last):
File "/home/paul/.cache/pypoetry/virtualenvs/sherlock-project-VJORHILj-py3.13/bin/sherlock", line 6, in <module>
sys.exit(main())
~~~~^^
File "/home/paul/Documents/sherlock/sherlock_project/sherlock.py", line 731, in main
if args.tor and (args.proxy is not None):
^^^^^^^^
AttributeError: 'Namespace' object has no attribute 'tor'
Tor has been deprecated and all mentions of such have been removed from the codebase in preparation for 0.17.0. This is likely due to the dereference of one of these removed variables.
Thanks for the catch, @ppfeister! 🙏 |
Hi @ppfeister — cleaned Tor leftovers and fixed CI: |
Add Proxy URL Validation
Summary
Implements regex validation for the
--proxy
argument to catch malformed URLs early and provide better error messages.Changes
sherlock_project/sherlock.py
http
,https
,socks4
, andsocks5
protocolsBenefits
Example
Testing