Skip to content

Conversation

shreyasNaik0101
Copy link
Contributor

This pull request resolves an issue where the site check for Lush Stories was producing false positives for non-existent usernames.

Problem:
The site redirects both valid and invalid profile URLs to a login page for unauthenticated users. This made it impossible for Sherlock to distinguish between a found and not-found profile, causing any username check to be reported as a success.

Solution:
After attempting several detection methods (status_code, response_url), it was determined that a reliable check is not possible without being logged in.

To improve the overall accuracy of the tool and prevent future false positives, this commit completely removes the Lush Stories site from data.json.

This fixes the issue reported by the user in the initial problem description.

Copy link
Contributor

github-actions bot commented Oct 4, 2025

Automatic validation of changes

Target F+ Check F- Check
CyberDefenders ✔️   Pass ✔️   Pass
SlideShare ❌   Fail ✔️   Pass
Lush Stories ✔️   Pass ✔️   Pass
threads ❌   Fail ✔️   Pass
Roblox ❌   Fail ✔️   Pass

Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences).

Copy link
Contributor

github-actions bot commented Oct 4, 2025

Automatic validation of changes

Target F+ Check F- Check
Lush Stories ✔️   Pass ✔️   Pass
CyberDefenders ❌   Fail ✔️   Pass
threads ❌   Fail ✔️   Pass
Roblox ❌   Fail ✔️   Pass
SlideShare ❌   Fail ✔️   Pass

Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences).

@ppfeister
Copy link
Member

Your PR desc mentions the removal of this site, but the diff simply modifies the site in-place

Which change was intended here?

@shreyasNaik0101 shreyasNaik0101 force-pushed the fix/lush-stories-false-positive branch from 69a5e31 to af73f93 Compare October 5, 2025 05:15
Copy link
Contributor

github-actions bot commented Oct 5, 2025

Automatic validation of changes

Target F+ Check F- Check
threads ❌   Fail ✔️   Pass
CyberDefenders ✔️   Pass ✔️   Pass
Roblox ❌   Fail ✔️   Pass
SlideShare ❌   Fail ✔️   Pass

Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences).

@shreyasNaik0101
Copy link
Contributor Author

@ppfeister You were right! I had committed the modification instead of the full removal. Please check now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants