Fix Issue #2782 - Resolve GeeksForGeeks False Positives#2785
Open
MaxwellOldshein wants to merge 2 commits intosherlock-project:masterfrom
Open
Fix Issue #2782 - Resolve GeeksForGeeks False Positives#2785MaxwellOldshein wants to merge 2 commits intosherlock-project:masterfrom
MaxwellOldshein wants to merge 2 commits intosherlock-project:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects the false positive issue for the GeeksForGeeks site as stated in: #2782. This was due to the fact that there is no longer a reliable way to check valid vs. invalid usernames for the GeeksForGeeks site, which previously leveraged the
status_codedetection methodology when it was working before.Known Valid Username Behavior -->
adam:Known Invalid Username Behavior -->
thisisatotallyfakeusername123456:Closes #2782.