Skip to content

Update node.js version to 22 #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shibd wants to merge 3 commits into from
Closed

Update node.js version to 22 #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
751d780
Update node.js version to 22
shibd Jul 15, 2025
4ababfc
test
shibd Jul 15, 2025
7e90d84
update
shibd Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci-build-release-napi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
- x64
- arm64
nodejs:
- 18
- 22
python:
- "3.10"
include:
Expand Down Expand Up @@ -100,7 +100,7 @@ jobs:
- 'linux_glibc'
- 'linux_musl'
nodejs:
- 18
- 22
cpu:
- {arch: 'x86_64', platform: 'x86_64'}
- {arch: 'aarch64', platform: 'arm64'}
Expand Down Expand Up @@ -152,7 +152,7 @@ jobs:
- x64
- x86
nodejs:
- 18
- 22
python:
- "3.10"
steps:
Expand Down
30 changes: 17 additions & 13 deletions .github/workflows/ci-pr-validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@ jobs:

steps:
- uses: actions/checkout@v3
- name: Use Node.js 18
- name: Use Node.js 22
uses: actions/setup-node@v3
with:
node-version: 18
node-version: 22

- name: Use Python ${{ matrix.python }}
uses: actions/setup-python@v3
Expand All @@ -61,10 +61,10 @@ jobs:

steps:
- uses: actions/checkout@v3
- name: Use Node.js 18
- name: Use Node.js 22
uses: actions/setup-node@v3
with:
node-version: 18
node-version: 22

- name: Use yarn install
run: |
Expand All @@ -82,7 +82,7 @@ jobs:
- x64
- arm64
nodejs:
- 18
- 22
python:
- "3.10"
include:
Expand Down Expand Up @@ -136,7 +136,7 @@ jobs:
- 'linux_glibc'
- 'linux_musl'
nodejs:
- 18
- 22
cpu:
- {arch: 'x86_64', platform: 'x86_64'}
- {arch: 'aarch64', platform: 'arm64'}
Expand Down Expand Up @@ -173,14 +173,18 @@ jobs:
- name: Test NAPI file in linux_glibc containers
if: matrix.image == 'linux_glibc'
run: |
./tests/load-test.sh node:16-buster ${{matrix.cpu.platform}}
./tests/load-test.sh node:16-bullseye ${{matrix.cpu.platform}}
./tests/load-test.sh node:22-bullseye ${{matrix.cpu.platform}}
./tests/load-test.sh node:19-buster ${{matrix.cpu.platform}}
./tests/load-test.sh node:19-bullseye ${{matrix.cpu.platform}}
Comment on lines +176 to 178
Copy link

Copilot AI Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The test order is inconsistent - Node.js 22 is tested first, then 19, then 18, then 16. Consider ordering tests from newest to oldest version consistently (22, 19, 18, 16) or oldest to newest for better readability.

Copilot uses AI. Check for mistakes.
./tests/load-test.sh node:18-buster ${{matrix.cpu.platform}}
./tests/load-test.sh node:18-bullseye ${{matrix.cpu.platform}}
./tests/load-test.sh node:16-buster ${{matrix.cpu.platform}}
./tests/load-test.sh node:16-bullseye ${{matrix.cpu.platform}}

- name: Test NAPI file in linux_musl containers
if: matrix.image == 'linux_musl'
run: |
./tests/load-test.sh node:22-alpine3.22 ${{matrix.cpu.platform}}
./tests/load-test.sh node:18-alpine3.15 ${{matrix.cpu.platform}}
./tests/load-test.sh node:16-alpine3.15 ${{matrix.cpu.platform}}

Expand All @@ -196,7 +200,7 @@ jobs:
- x64
- x86
nodejs:
- 18
- 22
python:
- "3.10"
steps:
Expand Down Expand Up @@ -260,10 +264,10 @@ jobs:

steps:
- uses: actions/checkout@v3
- name: Use Node.js 18
- name: Use Node.js 22
uses: actions/setup-node@v3
with:
node-version: 18
node-version: 22
cache: 'npm'
- name: Use Python ${{ matrix.python }}
uses: actions/setup-python@v3
Expand Down Expand Up @@ -298,10 +302,10 @@ jobs:

steps:
- uses: actions/checkout@v3
- name: Use Node.js 18
- name: Use Node.js 22
uses: actions/setup-node@v3
with:
node-version: 18
node-version: 22
cache: 'npm'

- name: Use Python ${{ matrix.python }}
Expand Down
2 changes: 1 addition & 1 deletion pkg/linux/Dockerfile_linux_glibc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

ARG NODE_VERSION

FROM node:${NODE_VERSION}-buster
FROM node:${NODE_VERSION}-bullseye

RUN apt-get update -y && \
apt-get install -y \
Expand Down
2 changes: 1 addition & 1 deletion pkg/linux/Dockerfile_linux_musl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

ARG NODE_VERSION

FROM node:${NODE_VERSION}-alpine3.15
FROM node:${NODE_VERSION}-alpine3.22

RUN apk add \
bash \
Expand Down
Loading