-
Notifications
You must be signed in to change notification settings - Fork 0
User interface implementation #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c905afa to
0f41060
Compare
22be0cf to
75af26c
Compare
a18c380 to
3d24571
Compare
f10ac31 to
d3d34d4
Compare
88dbfaa to
94a4d11
Compare
6031d93 to
d28bcfd
Compare
809159a to
8650abd
Compare
…guration instead.
…sion without factory.
fdee575 to
8bed1ae
Compare
hub/src/main/java/cloud/katta/workflows/UserKeysServiceImpl.java
Outdated
Show resolved
Hide resolved
hub/src/main/java/cloud/katta/workflows/UserKeysServiceImpl.java
Outdated
Show resolved
Hide resolved
hub/src/test/java/cloud/katta/workflows/AbstractHubWorkflowTest.java
Outdated
Show resolved
Hide resolved
hub/src/main/java/cloud/katta/protocols/hub/HubStorageLocationService.java
Show resolved
Hide resolved
...src/main/java/cloud/katta/protocols/hub/serializer/StorageProfileDtoWrapperDeserializer.java
Show resolved
Hide resolved
...src/main/java/cloud/katta/protocols/hub/serializer/StorageProfileDtoWrapperDeserializer.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements the user interface for device setup and vault creation workflows on macOS. The implementation moves from sheet-based controllers to alert-based controllers, following the alert refactoring dependency. Key changes include refactoring device setup prompts, removing the vault creation UI and service, and reorganizing storage session management.
- Migrates FirstLoginController and DeviceSetupController from SheetController to AlertController
- Removes CreateVaultBookmarkController UI and CreateVaultService implementation
- Refactors VaultService to return storage sessions instead of Host configurations
Reviewed Changes
Copilot reviewed 48 out of 48 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Adds maven-source-plugin configuration for source jar generation |
| osx/pom.xml | Changes binding dependency from 'binding' to 'osx' artifact |
| osx/src/main/java/cloud/katta/controller/PromptDeviceSetupCallback.java | New controller implementing DeviceSetupCallback for macOS prompts |
| osx/src/main/java/cloud/katta/controller/FirstLoginController.java | Refactored from SheetController to AlertController for first login flow |
| osx/src/main/java/cloud/katta/controller/DeviceSetupController.java | New AlertController for device setup with account key input |
| osx/src/main/java/cloud/katta/controller/DeviceSetupWithAccountKeyController.java | Removed legacy SheetController implementation |
| osx/src/main/java/cloud/katta/controller/CreateVaultBookmarkController.java | Removed vault creation UI controller |
| hub/src/test/resources/. | Test configuration updates for OAuth PKCE, logging, and storage profiles |
| hub/src/test/java/cloud/katta/workflows/. | Removed test files for CreateVaultService, CachingWoTService, and CachingUserKeysService |
| hub/src/test/java/cloud/katta/testsetup/. | Refactored test setup to remove MockableDeviceSetupCallback and update vault creation workflow |
| hub/src/test/java/cloud/katta/core/. | Updated synchronization tests with new vault creation approach |
| hub/src/main/resources/sts_create_bucket_inline_policy_template.json | Removed STS inline policy template |
| hub/src/main/java/cloud/katta/workflows/VaultServiceImpl.java | Refactored to return Session instead of Host for vault storage |
| hub/src/main/java/cloud/katta/workflows/VaultService.java | Updated interface to provide storage sessions instead of Host bookmarks |
| hub/src/main/java/cloud/katta/workflows/UserKeysServiceImpl.java | Updated to use AccountKeyAndDeviceName return type |
| hub/src/main/java/cloud/katta/workflows/CreateVaultService.java | Removed vault creation service implementation |
| hub/src/main/java/cloud/katta/workflows/Caching*.java | Removed caching service implementations |
| hub/src/main/java/cloud/katta/protocols/s3/STSChainedAssumeRoleRequestInterceptor.java | Refactored to accept HubSession and vaultId parameters |
| hub/src/main/java/cloud/katta/protocols/s3/S3AssumeRoleSession.java | Refactored to accept HubSession and vaultId in constructor |
| hub/src/main/java/cloud/katta/protocols/s3/S3AssumeRoleProtocol.java | Removed authorization field and renamed role ARN property |
| hub/src/main/java/cloud/katta/protocols/hub/serializer/. | Updated deserializers with new constructors and property handling |
| hub/src/main/java/cloud/katta/protocols/hub/exceptions/HubExceptionMappingService.java | Added warning log for exception mapping |
| hub/src/main/java/cloud/katta/protocols/hub/HubVaultStorageAwareComparisonService.java | New comparison service for vault storage |
| hub/src/main/java/cloud/katta/protocols/hub/HubVaultRegistry.java | Simplified vault registry implementation |
| hub/src/main/java/cloud/katta/protocols/hub/HubVaultListService.java | Refactored to use vault loading and storage sessions |
| hub/src/main/java/cloud/katta/protocols/hub/HubUVFVault.java | Major refactoring to manage storage sessions and vault creation |
| hub/src/main/java/cloud/katta/protocols/hub/HubStorageLocationService.java | New service for managing storage locations |
| hub/src/main/java/cloud/katta/protocols/hub/HubSession.java | Extensive refactoring to add feature implementations and user key caching |
| hub/src/main/java/cloud/katta/protocols/hub/HubProtocol.java | Added versioning mode configuration |
| hub/src/main/java/cloud/katta/protocols/hub/HubOAuthTokensCredentialsConfigurator.java | New configurator for OAuth token credentials |
| hub/src/main/java/cloud/katta/protocols/hub/HubGrantAccessSchedulerService.java | Refactored to instantiate API resources inline |
| hub/src/main/java/cloud/katta/protocols/hub/HubAwareProfile.java | New profile implementation for storage profiles |
| hub/src/main/java/cloud/katta/crypto/uvf/UvfMetadataPayloadPasswordCallback.java | Refactored to accept JSON string in constructor |
| hub/src/main/java/cloud/katta/core/DeviceSetupCallbackFactory.java | Removed factory implementation |
| hub/src/main/java/cloud/katta/core/DeviceSetupCallback.java | Updated interface to return AccountKeyAndDeviceName |
| hub/src/main/java/cloud/katta/core/DefaultDeviceSetupCallback.java | New default implementation for device setup callback |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


Resolve #87.
Depends on