Skip to content

Conversation

@dkocher
Copy link
Contributor

@dkocher dkocher commented Jun 13, 2025

@dkocher dkocher added this to the 1.0.0 milestone Jun 13, 2025
@dkocher dkocher requested a review from chenkins June 13, 2025 13:51
@dkocher dkocher self-assigned this Jun 13, 2025
@dkocher dkocher force-pushed the issues/87-macos branch 2 times, most recently from c905afa to 0f41060 Compare June 14, 2025 08:20
@dkocher
Copy link
Contributor Author

dkocher commented Jun 16, 2025

First Login

Screenshot 2025-06-16 at 22 16 19

Authorization Required

Screenshot 2025-06-16 at 22 16 02

@dkocher dkocher force-pushed the issues/87-macos branch 2 times, most recently from 22be0cf to 75af26c Compare June 17, 2025 11:02
@chenkins chenkins marked this pull request as draft June 17, 2025 11:20
@chenkins chenkins changed the title [WiP] User interface implementation User interface implementation Jun 17, 2025
@dkocher dkocher force-pushed the issues/87-macos branch from f30af43 to 38e9aca Compare July 5, 2025 06:22
@dkocher dkocher marked this pull request as ready for review July 5, 2025 06:23
@dkocher dkocher force-pushed the issues/87-macos branch from 38e9aca to 5f6712b Compare July 9, 2025 12:23
@dkocher dkocher force-pushed the issues/87-macos branch 2 times, most recently from f10ac31 to d3d34d4 Compare September 4, 2025 19:21
@dkocher dkocher force-pushed the issues/87-macos branch 2 times, most recently from 88dbfaa to 94a4d11 Compare October 14, 2025 13:38
@dkocher dkocher linked an issue Oct 15, 2025 that may be closed by this pull request
1 task
@dkocher dkocher force-pushed the issues/87-macos branch 3 times, most recently from 6031d93 to d28bcfd Compare October 15, 2025 15:31
@dkocher dkocher marked this pull request as draft October 15, 2025 15:31
@dkocher dkocher force-pushed the issues/87-macos branch 4 times, most recently from 809159a to 8650abd Compare October 16, 2025 11:45
@dkocher dkocher requested review from chenkins and Copilot October 24, 2025 15:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the user interface for device setup and vault creation workflows on macOS. The implementation moves from sheet-based controllers to alert-based controllers, following the alert refactoring dependency. Key changes include refactoring device setup prompts, removing the vault creation UI and service, and reorganizing storage session management.

  • Migrates FirstLoginController and DeviceSetupController from SheetController to AlertController
  • Removes CreateVaultBookmarkController UI and CreateVaultService implementation
  • Refactors VaultService to return storage sessions instead of Host configurations

Reviewed Changes

Copilot reviewed 48 out of 48 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
pom.xml Adds maven-source-plugin configuration for source jar generation
osx/pom.xml Changes binding dependency from 'binding' to 'osx' artifact
osx/src/main/java/cloud/katta/controller/PromptDeviceSetupCallback.java New controller implementing DeviceSetupCallback for macOS prompts
osx/src/main/java/cloud/katta/controller/FirstLoginController.java Refactored from SheetController to AlertController for first login flow
osx/src/main/java/cloud/katta/controller/DeviceSetupController.java New AlertController for device setup with account key input
osx/src/main/java/cloud/katta/controller/DeviceSetupWithAccountKeyController.java Removed legacy SheetController implementation
osx/src/main/java/cloud/katta/controller/CreateVaultBookmarkController.java Removed vault creation UI controller
hub/src/test/resources/. Test configuration updates for OAuth PKCE, logging, and storage profiles
hub/src/test/java/cloud/katta/workflows/. Removed test files for CreateVaultService, CachingWoTService, and CachingUserKeysService
hub/src/test/java/cloud/katta/testsetup/. Refactored test setup to remove MockableDeviceSetupCallback and update vault creation workflow
hub/src/test/java/cloud/katta/core/. Updated synchronization tests with new vault creation approach
hub/src/main/resources/sts_create_bucket_inline_policy_template.json Removed STS inline policy template
hub/src/main/java/cloud/katta/workflows/VaultServiceImpl.java Refactored to return Session instead of Host for vault storage
hub/src/main/java/cloud/katta/workflows/VaultService.java Updated interface to provide storage sessions instead of Host bookmarks
hub/src/main/java/cloud/katta/workflows/UserKeysServiceImpl.java Updated to use AccountKeyAndDeviceName return type
hub/src/main/java/cloud/katta/workflows/CreateVaultService.java Removed vault creation service implementation
hub/src/main/java/cloud/katta/workflows/Caching*.java Removed caching service implementations
hub/src/main/java/cloud/katta/protocols/s3/STSChainedAssumeRoleRequestInterceptor.java Refactored to accept HubSession and vaultId parameters
hub/src/main/java/cloud/katta/protocols/s3/S3AssumeRoleSession.java Refactored to accept HubSession and vaultId in constructor
hub/src/main/java/cloud/katta/protocols/s3/S3AssumeRoleProtocol.java Removed authorization field and renamed role ARN property
hub/src/main/java/cloud/katta/protocols/hub/serializer/. Updated deserializers with new constructors and property handling
hub/src/main/java/cloud/katta/protocols/hub/exceptions/HubExceptionMappingService.java Added warning log for exception mapping
hub/src/main/java/cloud/katta/protocols/hub/HubVaultStorageAwareComparisonService.java New comparison service for vault storage
hub/src/main/java/cloud/katta/protocols/hub/HubVaultRegistry.java Simplified vault registry implementation
hub/src/main/java/cloud/katta/protocols/hub/HubVaultListService.java Refactored to use vault loading and storage sessions
hub/src/main/java/cloud/katta/protocols/hub/HubUVFVault.java Major refactoring to manage storage sessions and vault creation
hub/src/main/java/cloud/katta/protocols/hub/HubStorageLocationService.java New service for managing storage locations
hub/src/main/java/cloud/katta/protocols/hub/HubSession.java Extensive refactoring to add feature implementations and user key caching
hub/src/main/java/cloud/katta/protocols/hub/HubProtocol.java Added versioning mode configuration
hub/src/main/java/cloud/katta/protocols/hub/HubOAuthTokensCredentialsConfigurator.java New configurator for OAuth token credentials
hub/src/main/java/cloud/katta/protocols/hub/HubGrantAccessSchedulerService.java Refactored to instantiate API resources inline
hub/src/main/java/cloud/katta/protocols/hub/HubAwareProfile.java New profile implementation for storage profiles
hub/src/main/java/cloud/katta/crypto/uvf/UvfMetadataPayloadPasswordCallback.java Refactored to accept JSON string in constructor
hub/src/main/java/cloud/katta/core/DeviceSetupCallbackFactory.java Removed factory implementation
hub/src/main/java/cloud/katta/core/DeviceSetupCallback.java Updated interface to return AccountKeyAndDeviceName
hub/src/main/java/cloud/katta/core/DefaultDeviceSetupCallback.java New default implementation for device setup callback

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chenkins chenkins merged commit 6157845 into main Oct 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implementation of device setup callback with user interface

3 participants