Review UVFMetadata compliance. #216
Draft
+58
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenkins
commented
Oct 31, 2025
hub/src/main/java/cloud/katta/crypto/uvf/UvfMetadataPayload.java
Outdated
Show resolved
Hide resolved
chenkins
force-pushed
the
209-uvf-compliance
branch
2 times, most recently
from
3cea6e3 to
c981056
Compare
chenkins
commented
Nov 4, 2025
chenkins
commented
Nov 4, 2025
|
|
||
| @Test | ||
| void decryptWithRecoveryKey() throws ParseException, JOSEException, NoSuchAlgorithmException, InvalidKeySpecException, NotECKeyException, JsonProcessingException { | ||
| @Disabled("TODO uvf.spec.version missing in protected.") |
Contributor
Author
There was a problem hiding this comment.
chenkins
force-pushed
the
209-uvf-compliance
branch
from
a1f129d to
7160037
Compare
chenkins
commented
Nov 6, 2025
Comment on lines
+329
to
+332
| final Object uvfSpecVersion = jweObject.getHeader().getCustomParams().get(UVF_SPEC_VERSION_KEY_PARAM); | ||
| if(!"1".equals(uvfSpecVersion)) { | ||
| throw new SecurityFailure(String.format("Unexpected value for critical header %s: found %s, expected \"1\"", UVF_SPEC_VERSION_KEY_PARAM, uvfSpecVersion)); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
@overheadhunter do we need/want to verify the spec version? Same then web.
https://datatracker.ietf.org/doc/html/rfc7515#section-4.1.11
Recipients MAY consider the JWS to be invalid if the critical
list contains any Header Parameter names defined by this
specification or [JWA] for use with JWS or if any other constraints on its use are violated.
There was a problem hiding this comment.
Yes, needs to be checked. Also it needs to be an integer, not a String!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #209