Replace shell backticks with Process.new for better escaping#35
Merged
shijimasoft merged 1 commit intoshijimasoft:mainfrom May 19, 2025
Merged
Replace shell backticks with Process.new for better escaping#35shijimasoft merged 1 commit intoshijimasoft:mainfrom
shijimasoft merged 1 commit intoshijimasoft:mainfrom
Conversation
This avoids issues with filenames containing spaces and improves reliability when passing arguments to external tools.
Contributor
Author
|
I wasn’t sure if you'd be open to this change, but thought it might be useful. Happy to adjust or close if not the direction you want to take. |
Owner
|
Thanks for your help, I will merge the changes :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids issues with filenames containing spaces and improves reliability when passing arguments to external tools.
Fixes #31