ci: run node.js esm tests on commit

Author: shijistar

.github/workflows/reusable-test.yml

@@ -16,7 +16,12 @@ on:
         default: false
 
 jobs:
-  node-modules-cache:
+  # This job is used to cache node_modules and build output
+  # 1. Install latest dependencies
+  # 2. Cache node_modules
+  # 3. Build package
+  # 4. Cache build output
+  install-and-build:
     if: ${{ inputs.use-matrix == true }}
     runs-on: ubuntu-latest
     steps:
@@ -63,55 +68,6 @@ jobs:
           name: modern-node-modules-${{ hashFiles('**/package-lock.json') }}
           path: node_modules
 
-  node-modules-legacy-cache:
-    if: ${{ inputs.use-matrix == true }}
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-
-      - name: Use Node.js ${{ vars.DEFAULT_NODE_VERSION }}
-        uses: actions/setup-node@v4
-        with:
-          node-version: ${{ vars.DEFAULT_NODE_VERSION }}
-
-      - name: Try to restore legacy node_modules cache
-        id: node_modules_cache
-        uses: actions/cache@v4
-        with:
-          path: node_modules
-          key: ${{ runner.os }}-legacy-node-modules-${{ hashFiles('**/package-lock.json') }}-${{ hashFiles('**/package-legacy-node.json') }}
-
-      - name: Downgrade package.json legacy dependencies
-        if: steps.node_modules_cache.outputs.cache-hit != 'true'
-        run: npm run prepare-legacy-node
-
-      - name: Install dependencies
-        if: steps.node_modules_cache.outputs.cache-hit != 'true'
-        run: npm install --legacy-peer-deps --ignore-scripts --no-package-lock
-
-  # This job is used to run tests on modern Node.js versions
-  # 1. Use default Node.js
-  # 2. Install latest dependencies
-  # 3. Cache node_modules
-  build-for-node-modern:
-    if: ${{ inputs.use-matrix == true }}
-    runs-on: ubuntu-latest
-    needs: node-modules-cache
-    steps:
-      - uses: actions/checkout@v4
-
-      - name: Use Node.js ${{ vars.DEFAULT_NODE_VERSION }}
-        uses: actions/setup-node@v4
-        with:
-          node-version: ${{ vars.DEFAULT_NODE_VERSION }}
-
-      - name: Restore modern node_modules cache
-        id: node_modules_cache
-        uses: actions/cache@v4
-        with:
-          path: node_modules
-          key: ${{ runner.os }}-modern-node-modules-${{ hashFiles('**/package-lock.json') }}
-
       - name: Build package
         run: npm run build
 
@@ -138,12 +94,37 @@ jobs:
             es
             es-legacy
             umd
+  node-modules-legacy-cache:
+    if: ${{ inputs.use-matrix == true }}
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Use Node.js ${{ vars.DEFAULT_NODE_VERSION }}
+        uses: actions/setup-node@v4
+        with:
+          node-version: ${{ vars.DEFAULT_NODE_VERSION }}
+
+      - name: Try to restore legacy node_modules cache
+        id: node_modules_cache
+        uses: actions/cache@v4
+        with:
+          path: node_modules
+          key: ${{ runner.os }}-legacy-node-modules-${{ hashFiles('**/package-lock.json') }}-${{ hashFiles('**/package-legacy-node.json') }}
+
+      - name: Downgrade package.json legacy dependencies
+        if: steps.node_modules_cache.outputs.cache-hit != 'true'
+        run: npm run prepare-legacy-node
+
+      - name: Install dependencies
+        if: steps.node_modules_cache.outputs.cache-hit != 'true'
+        run: npm install --legacy-peer-deps --ignore-scripts --no-package-lock
 
   # Run ts-tests on default Node.js version
   run-jest-ts:
     if: ${{ inputs.use-matrix == true }}
     runs-on: ubuntu-latest
-    needs: build-for-node-modern
+    needs: install-and-build
     steps:
       - uses: actions/checkout@v4
 
@@ -166,7 +147,7 @@ jobs:
   run-jest-cjs:
     if: ${{ inputs.use-matrix == true }}
     runs-on: ubuntu-latest
-    needs: build-for-node-modern
+    needs: install-and-build
     strategy:
       matrix:
         node-version: [16.x, 17.x, 18.x, 19.x, 20.x, 21.x, 22.x, 23.x, 24.x]
@@ -204,7 +185,7 @@ jobs:
   run-jest-cjs-legacy:
     if: ${{ inputs.use-matrix == true }}
     runs-on: ubuntu-latest
-    needs: [build-for-node-modern, node-modules-legacy-cache]
+    needs: [install-and-build, node-modules-legacy-cache]
     strategy:
       matrix:
         node-version: [7.x, 8.x, 9.x, 10.x, 11.x, 12.x, 13.x, 14.x, 15.x]
@@ -242,7 +223,7 @@ jobs:
   run-jest-esm:
     if: ${{ inputs.use-matrix == true }}
     runs-on: ubuntu-latest
-    needs: build-for-node-modern
+    needs: install-and-build
     strategy:
       matrix:
         node-version: [16.x, 17.x, 18.x, 19.x, 20.x, 21.x, 22.x, 23.x, 24.x]
@@ -280,7 +261,7 @@ jobs:
   run-e2e:
     if: ${{ inputs.use-matrix == true }}
     runs-on: ubuntu-latest
-    needs: [build-for-node-modern, node-modules-cache]
+    needs: [install-and-build]
     steps:
       - uses: actions/checkout@v4