Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates NuGet dependencies (notably migrating tests to xUnit v3) and adjusts the test suite to use xUnit’s built-in conditional skipping instead of a custom platform-specific attribute.
Changes:
- Upgrade test infrastructure packages (Microsoft.NET.Test.Sdk, xUnit runner, xUnit v3, StaFact) and switch test projects to
OutputType=Exe. - Replace
PlatformSpecificFactusage with[Fact(..., SkipUnless = ...)]and add OS-detection helpers. - Minor test code cleanups (remove no-longer-needed usings, tighten assertions in FileStorage test).
Reviewed changes
Copilot reviewed 35 out of 35 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| test/OpenCvSharp.Tests/xphoto/XPhotoTest.cs | Removes xUnit Abstractions using as part of xUnit v3 migration. |
| test/OpenCvSharp.Tests/ximgproc/SuperpixelTest.cs | Replaces platform-specific attribute with SkipUnless-based Fact; adds OS check helper. |
| test/OpenCvSharp.Tests/xfeatures2d/SURFTest.cs | Removes xUnit Abstractions using as part of xUnit v3 migration. |
| test/OpenCvSharp.Tests/wechat_qrcode/WeChatQRCodeTest.cs | Removes xUnit Abstractions using as part of xUnit v3 migration. |
| test/OpenCvSharp.Tests/videoio/VideoWriterTest.cs | Removes xUnit Abstractions using as part of xUnit v3 migration. |
| test/OpenCvSharp.Tests/videoio/VideoCaptureTest.cs | Converts platform-specific facts to SkipUnless and adds OS checks. |
| test/OpenCvSharp.Tests/text/OCRTesseractTest.cs | Removes xUnit Abstractions using as part of xUnit v3 migration. |
| test/OpenCvSharp.Tests/system/AppDomainTest.cs | Removes xUnit Abstractions using as part of xUnit v3 migration. |
| test/OpenCvSharp.Tests/stitching/StitchingTest.cs | Removes xUnit Abstractions using as part of xUnit v3 migration. |
| test/OpenCvSharp.Tests/stitching/CvDetailTest.cs | Converts platform-specific fact to SkipUnless and adds OS checks. |
| test/OpenCvSharp.Tests/ml/ANN_MLPTest.cs | Removes xUnit Abstractions using as part of xUnit v3 migration. |
| test/OpenCvSharp.Tests/imgcodecs/ImgCodecsTest.cs | Adds OS check and converts Windows-only tests to SkipUnless. |
| test/OpenCvSharp.Tests/features2d/SIFTTest.cs | Removes xUnit Abstractions using as part of xUnit v3 migration. |
| test/OpenCvSharp.Tests/features2d/ORBTest.cs | Removes xUnit Abstractions using as part of xUnit v3 migration. |
| test/OpenCvSharp.Tests/features2d/FastFeatureDetectorTest.cs | Removes xUnit Abstractions using as part of xUnit v3 migration. |
| test/OpenCvSharp.Tests/features2d/BOWImgDescriptorExtractorTest.cs | Removes xUnit Abstractions using as part of xUnit v3 migration. |
| test/OpenCvSharp.Tests/face/LBPHFaceRecognizerTest.cs | Removes xUnit Abstractions using as part of xUnit v3 migration. |
| test/OpenCvSharp.Tests/dnn/YoloTest.cs | Removes xUnit Abstractions using as part of xUnit v3 migration. |
| test/OpenCvSharp.Tests/dnn/TensorflowTest.cs | Converts platform-specific facts to SkipUnless and adds OS checks. |
| test/OpenCvSharp.Tests/dnn/NetTest.cs | Removes xUnit Abstractions using as part of xUnit v3 migration. |
| test/OpenCvSharp.Tests/dnn/EastTextDetectionTest.cs | Removes xUnit Abstractions using as part of xUnit v3 migration. |
| test/OpenCvSharp.Tests/dnn/CaffeTest.cs | Removes xUnit Abstractions using as part of xUnit v3 migration. |
| test/OpenCvSharp.Tests/core/UtilityTest.cs | Removes xUnit Abstractions using as part of xUnit v3 migration. |
| test/OpenCvSharp.Tests/core/SolveEquationTest.cs | Removes xUnit Abstractions using as part of xUnit v3 migration. |
| test/OpenCvSharp.Tests/core/MatTest.cs | Removes xUnit Abstractions using as part of xUnit v3 migration. |
| test/OpenCvSharp.Tests/core/FileStorageTest.cs | Makes FileNode null checks explicit before reading Mats. |
| test/OpenCvSharp.Tests/calib3d/Calib3dTest.cs | Removes xUnit Abstractions using as part of xUnit v3 migration. |
| test/OpenCvSharp.Tests/TestBase.cs | Adds shared OS-detection properties for SkipUnless. |
| test/OpenCvSharp.Tests/PlatformSpecificFactAttribute.cs | Deletes the custom platform-specific xUnit attribute implementation. |
| test/OpenCvSharp.Tests/OpenCvSharp.Tests.csproj | Updates test NuGets and switches test output type to Exe. |
| test/OpenCvSharp.Tests.Windows/OpenCvSharp.Tests.Windows.csproj | Updates test NuGets and switches test output type to Exe. |
| test/OpenCvSharp.Tests.Windows/BitmapConverterTest.cs | Removes xUnit Abstractions using as part of xUnit v3 migration. |
| src/OpenCvSharp/OpenCvSharp.csproj | Updates SourceLink GitHub package version. |
| src/OpenCvSharp.WpfExtensions/OpenCvSharp.WpfExtensions.csproj | Updates System.Drawing.Common package version. |
| src/OpenCvSharp.Extensions/OpenCvSharp.Extensions.csproj | Updates System.Drawing.Common and SourceLink GitHub package versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.