Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the OpenCvSharp project from using standalone .nuspec files to SDK-style .csproj files for NuGet package generation. This modernization simplifies the build process by consolidating package metadata directly into project files and using dotnet pack instead of nuget pack.
Changes:
- Migrated all NuGet package metadata from .nuspec files to SDK-style .csproj files for core libraries and runtime packages
- Updated GitHub Actions workflows to use
dotnet packwith version parameters instead of nuget pack with XML manipulation - Upgraded actions/upload-artifact from v4 to v6 in some workflows
- Updated target frameworks for some runtime packages (netcoreapp2.1 → netcoreapp3.1)
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| src/OpenCvSharp/OpenCvSharp.csproj | Added NuGet package metadata and changed PackageId to OpenCvSharp4 |
| src/OpenCvSharp.WpfExtensions/OpenCvSharp.WpfExtensions.csproj | Added NuGet package metadata including PackageId OpenCvSharp4.WpfExtensions |
| src/OpenCvSharp.Extensions/OpenCvSharp.Extensions.csproj | Added NuGet package metadata and changed PackageId to OpenCvSharp4.Extensions |
| nuget/OpenCvSharp4.runtime.win.csproj | New file: migrated from .nuspec to .csproj for Windows runtime package |
| nuget/OpenCvSharp4.runtime.wasm.csproj | Migrated from .nuspec to .csproj for WebAssembly runtime package |
| nuget/OpenCvSharp4.runtime.uwp.csproj | New file: migrated from .nuspec to .csproj for UWP runtime package |
| nuget/OpenCvSharp4.runtime.osx.10.15-x64.csproj | Migrated from .nuspec to .csproj for macOS runtime package |
| nuget/OpenCvSharp4.runtime.linux-arm.csproj | Migrated from .nuspec to .csproj for Linux ARM runtime package |
| nuget/OpenCvSharp4.official.runtime.ubuntu.24.04-x64.csproj | Migrated from .nuspec to .csproj for Ubuntu 24.04 runtime package |
| nuget/OpenCvSharp4.official.runtime.ubuntu.22.04-x64.csproj | Migrated from .nuspec to .csproj for Ubuntu 22.04 runtime package |
| nuget/OpenCvSharp4.official.runtime.linux-x64.csproj | Migrated from .nuspec to .csproj for generic Linux runtime package |
| nuget/OpenCvSharp4.Windows.csproj | New file: migrated from .nuspec to .csproj for Windows meta-package |
| .github/workflows/windows.yml | Updated to use dotnet pack and removed nuspec version manipulation; upgraded to upload-artifact@v6 |
| .github/workflows/wasm.yml | Updated to use dotnet pack with version parameter |
| .github/workflows/ubuntu24.yml | Updated to use dotnet pack with version parameter; upgraded to upload-artifact@v6 |
| .github/workflows/ubuntu22.yml | Updated to use dotnet pack with version parameter; upgraded to upload-artifact@v6 |
| .github/workflows/linux-arm.yml | Updated to use dotnet pack with version parameter; upgraded to upload-artifact@v6 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.