Fix: Correct WASM library filename from libOpenCvSharpExtern.a to OpenCvSharpExtern.a#1838
Fix: Correct WASM library filename from libOpenCvSharpExtern.a to OpenCvSharpExtern.a#1838asheesh1996 wants to merge 1 commit intoshimat:mainfrom
Conversation
…nCvSharpExtern.a The emcmake/cmake build outputs OpenCvSharpExtern.a (without 'lib' prefix), but the project configuration was referencing libOpenCvSharpExtern.a, causing a NativeFileReference error in the WASM runtime package build. Changes: - Update .github/workflows/wasm.yml: Fix copy command filename - Update nuget/OpenCvSharp4.runtime.wasm.csproj: Fix NativeFileReference path This resolves the error: 'Could not find NativeFileReference ...\OpenCvSharpExtern.a'
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR updates WASM build artifacts and packaging configuration. The artifact filename changes from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Comment |
|
Thank you for the report! The actual mismatch is in |
Description
Fixes the NativeFileReference error in the WASM runtime package build caused by a filename mismatch.
Problem
The emcmake/cmake build outputs
OpenCvSharpExtern.a(without 'lib' prefix), but the project configuration was referencinglibOpenCvSharpExtern.a, causing:Changes
.github/workflows/wasm.yml: Updated copy command fromlibOpenCvSharpExtern.a→OpenCvSharpExtern.anuget/OpenCvSharp4.runtime.wasm.csproj: Updated NativeFileReference path fromlibOpenCvSharpExtern.a→OpenCvSharpExtern.aTesting
This fix resolves the WASM runtime package build error where the NativeFileReference could not locate the compiled library file.
Summary by CodeRabbit