Merged
Conversation
- Update `compileSdkVer` and `targetSdkVer` from "34" to "35" - Update `androidGradlePlugin` from "8.5.2" to "8.10.0" - Update `androidTools` from "31.6.0" to "31.10.0" - Update `kotlin` from "2.0.20" to "2.1.21" - Update `ksp` from "2.0.20-1.0.25" to "2.1.21-2.0.1" - Update `androidDesugarJdkLibs` from "2.1.2" to "2.1.5" - Update `kotlinxCoroutines` from "1.8.1" to "1.10.1" - Update `androidxCore` from "1.13.1" to "1.16.0" - Update `androidxActivity` from "1.9.2" to "1.10.1" - Update `androidxStartup` from "1.1.1" to "1.2.0" - Update `androidxLifecycle` from "2.8.5" to "2.9.0" - Update `androidxDataStore` from "1.1.1" to "1.1.7" - Update `androidxComposeBom` from "2024.09.00" to "2025.05.01" - Update `hilt` from "2.51.1" to "2.56" - Update `androidxNavigation` from "2.8.0" to "2.9.0" - Update `room` from "2.6.1" to "2.7.1" - Update `kover` from "0.8.3" to "0.9.1" - Update Gradle wrapper distributionUrl from `gradle-8.7-bin.zip` to `gradle-8.11.1-bin.zip`
The strong skipping mode in Jetpack Compose, which allows composables with unstable parameters to be skipped, has been disabled. This change reverts to the default Compose compiler behavior where only composables with stable parameters are skippable.
There was a problem hiding this comment.
Pull Request Overview
This PR improves the project's environment by updating CI/CD configurations, dependency versions, and network handling for local testing, while also enabling debugging and adjusting Compose compiler settings.
- Upgraded Gradle and library dependencies.
- Replaced the network binding with a LocalDataSource for mocking network calls.
- Adjusted CI/CD workflows and build configurations for improved local and release builds.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| gradle/wrapper/gradle-wrapper.properties | Upgraded Gradle distribution URL to version 8.11.1. |
| gradle/libs.versions.toml | Updated various dependency versions including compileSdk, Android Gradle Plugin, Kotlin, and others. |
| core/network/src/main/kotlin/io/github/shinhyo/brba/core/network/di/NetworkModule.kt | Changed network binding to use LocalDataSource in place of RetrofitNetwork; contains commented-out alternative binding. |
| core/network/src/main/kotlin/io/github/shinhyo/brba/core/network/LocalDataSource.kt | Added a new LocalDataSource implementation to mock network calls. |
| build-logic/convention/src/main/kotlin/io/github/shinhyo/brba/buildlogic/AndroidCompose.kt | Removed enabling of strong skipping mode for Compose compiler. |
| build-logic/convention/src/main/kotlin/brba.android.application.gradle.kts | Enabled debug mode for local testing. |
| build-logic/convention/build.gradle.kts | Updated Kotlin compile options. |
| .github/workflows/CI.yaml | Modified CI workflow name, timeouts, caching keys, and Gradle setup action. |
| .github/workflows/CD.yaml | Added a new CD workflow for tag-based release builds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI/CD Configuration
Added GitHub Actions workflows for release and build processes
LocalDataSource Implementation
Implemented a local data source to mock network calls
Enabled debug mode for easier local testing
Compose Compiler Settings
Disabled strong skipping mode for better Compose behavior during development
Dependency Updates
Updated library versions to their latest compatible releases