Open
Conversation
I suspect this was the cause of the "new compiles even on a warm cache" behavior I was seeing, though haven't 100% confirmed it. Python `set()` iteration order is nondeterministic when you create a new process. So the same args could produce different `instance_descriptor`s and have false cache misses.
Based on the discussion in triton-lang#700, this PR enables downloading pybind11 in `setup.py` without `git submodule` instead of copy-pasting pybind11 code. The downloaded pybind11 will be in `~/.triton/pybind` (like `llvm`).
…ng#708) This allows compiling in a subprocess. I'm not seeing a ton of speedup from this, but figure it is a good change anyway.
shintaro-iwasaki
force-pushed
the
siwasaki/pr/fix_phi_inliner
branch
2 times, most recently
from
94bebfa to
7ee6264
Compare
…iton-lang#726) Without this patch, a debug version of python complains that: ``` Fatal Python error: Python memory allocator called without holding the GIL Python runtime state: initialized ```
For example, phi-nodes can refer to an instruction after its appearance. Let's create all the new instructions and then replace their operands.
replace_uses_of_with() does not replace basic blocks of phi nodes. Let's replace them explicitly.
shintaro-iwasaki
force-pushed
the
siwasaki/pr/fix_phi_inliner
branch
from
7ee6264 to
603c882
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.