build_runnerを実行済みか確認するジョブを追加#706
Open
poppingmoon wants to merge 3 commits intoshiosyakeyakini-info:developfrom
Open
build_runnerを実行済みか確認するジョブを追加#706poppingmoon wants to merge 3 commits intoshiosyakeyakini-info:developfrom
poppingmoon wants to merge 3 commits intoshiosyakeyakini-info:developfrom
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #706 +/- ##
========================================
Coverage 26.68% 26.68%
========================================
Files 340 340
Lines 19236 19236
========================================
Hits 5133 5133
Misses 14103 14103 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
poppingmoon
force-pushed
the
check-build-diff
branch
from
dbb8cbd to
085e6e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FreezedやRiverpod関連のクラスやルーターを変更した後は
dart run build_runner build -dを実行しなければ生成されたファイルが更新されず不具合の原因になりますが、これは忘れやすいのでPR時にGitHub Actionsでbuild_runnerを実行して差分が発生しないか確認するようにしました。また、build_runnerは時間がかかるのでtestと並列に実行するようにしました