Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces functionality to manage the visibility of poll results in notes. It adds a new field
isPollResultOpenedto theNoteStatusclass and integrates it into theNoteRepositoryfor state management. Additionally, it updates theNoteVotewidget to utilize this new state for handling poll result visibility. Mock implementations for testing this functionality have also been updated.Feature Addition: Poll Result Visibility Management
lib/repository/note_repository.dart: Added a new fieldisPollResultOpenedto theNoteStatusclass and implemented methods inNoteRepositoryto toggle, set, and retrieve the poll result visibility state. The initial visibility state is determined based on poll expiration and voting status. [1] [2] [3]Integration with
NoteVoteWidgetlib/view/common/misskey_notes/note_vote.dart: Updated theNoteVotewidget to use the poll result visibility state fromNoteRepositoryinstead of local hook state. Voting success now triggers the visibility of poll results, and tapping to toggle visibility is handled via the repository. [1] [2] [3] [4] [5]Code Generation Updates
lib/repository/note_repository.freezed.dart: Updated generated code to include the newisPollResultOpenedfield inNoteStatus. This includes updates to constructors, copy methods, equality checks, and hash code calculations. [1] [2] [3] [4] [5] [6] [7] [8] [9]Mock Implementation for Testing
test/test_util/mock.mocks.dart: Added mock implementations for the new methods inNoteRepository(togglePollResult,setPollResultOpened,getPollResultOpened) to facilitate testing.