Open
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #845 +/- ##
===========================================
- Coverage 28.12% 28.12% -0.01%
===========================================
Files 375 375
Lines 22445 22446 +1
===========================================
Hits 6313 6313
- Misses 16132 16133 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
next.misskey.ioはMisskey 2025.4.1をベースにしているため #728 のレジストリの変更が起こります
#729 では
chat/historyが存在するかどうかで2025.4.0以降かどうか判定していましたが、next.misskey.ioではチャット系のエンドポイントをコメントアウトする形でチャット機能が無効化されていますそのため、リアクションの一括追加時にレジストリを開く挙動になっています
このPRでは
i/read-all-unread-notesが存在しないことを2025.4.0以降と判定する条件に加えましたこのエンドポイントはかなり昔から存在していましたが2025.4.0で削除されました
エンドポイントの増減でバージョンを推定する方法で今回使えるものはチャット関連のものと
i/read-all-unread-notesしかありませんでしたmisskey-dev/misskey@2025.3.1...2025.4.0#diff-6f3c4d0fd38f7935afad575df2b07a1bc86d276adc9c92b3a0ca42410c03cb4e