Fix keywords used as constant names resetting parser state#257
Merged
Fix keywords used as constant names resetting parser state#257
Conversation
PHP reserved keywords (NAMESPACE, CLASS, INTERFACE, TRAIT, ENUM) can be used as class constant names. When accessed (e.g., Foo::NAMESPACE) or defined (e.g., const NAMESPACE = 'value'), PHP still tokenizes them as their keyword type (T_NAMESPACE, T_CLASS, etc.). This caused the parser to incorrectly: - Reset use statements when encountering T_NAMESPACE as a constant - Corrupt $inClassLevel tracking when encountering T_CLASS/etc. The fix checks if the keyword is preceded by T_DOUBLE_COLON or T_CONST before applying the keyword-specific handling.
janedbal
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP reserved keywords (NAMESPACE, CLASS, INTERFACE, TRAIT, ENUM) can be used as class constant names. When accessed (e.g., Foo::NAMESPACE) or defined (e.g., const NAMESPACE = 'value'), PHP still tokenizes them as their keyword type (T_NAMESPACE, T_CLASS, etc.).
This caused the parser to incorrectly:
The fix checks if the keyword is preceded by T_DOUBLE_COLON or T_CONST before applying the keyword-specific handling.
Resolves #256