Exclude method with AsMessageHandler attribute #236
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll add some tests if it's ok to you @janedbal |
janedbal
reviewed
Jul 22, 2025
gaetan-petit
force-pushed
the
patch-1
branch
2 times, most recently
from
aa22b8b to
b6ee684
Compare
janedbal
requested changes
Jul 24, 2025
| { | ||
| $class = $method->getDeclaringClass(); | ||
|
|
||
| return $this->hasAttribute($class, 'Symfony\Component\Messenger\Attribute\AsMessageHandler') |
There was a problem hiding this comment.
I dont think this is correct. When used on class, I believe it only calls a single method (by default __invoke and optionally the one stated in the attribute)
Currently, you mark all methods as used in a class marked with this attribute.
We need test for such behaviour.
|
I'm sorry I didn't update this PR, I'm in vacation, I'll do it later |
|
This got implemented in #247 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it should filter out methods with the AsMessageHandler attribute as they are reported as dead code while they're probably not.