Make all classes final

phpcs.xml.dist

@@ -18,6 +18,7 @@
         <exclude name="SlevomatCodingStandard.Commenting.ForbiddenAnnotations.AnnotationForbidden"/><!-- It removes @dataProvider, but PHPUnit 9 does not yet have #[DataProvider] -->
     </rule>
 
+    <rule ref="SlevomatCodingStandard.Classes.RequireAbstractOrFinal"/>
     <rule ref="SlevomatCodingStandard.Functions.DisallowTrailingCommaInDeclaration">
         <properties>
             <property name="onlySingleLine" value="false"/>

src/Collector/ClassDefinitionCollector.php

@@ -34,7 +34,7 @@
  *       interfaces: array<string, null>,
  *  }>
  */
-class ClassDefinitionCollector implements Collector
+final class ClassDefinitionCollector implements Collector
 {
 
     private ReflectionProvider $reflectionProvider;

src/Collector/ConstantFetchCollector.php

@@ -29,7 +29,7 @@
 /**
  * @implements Collector<Node, list<string>>
  */
-class ConstantFetchCollector implements Collector
+final class ConstantFetchCollector implements Collector
 {
 
     use BufferedUsageCollector;

src/Collector/MethodCallCollector.php

@@ -30,7 +30,7 @@
 /**
  * @implements Collector<Node, list<string>>
  */
-class MethodCallCollector implements Collector
+final class MethodCallCollector implements Collector
 {
 
     use BufferedUsageCollector;

src/Collector/ProvidedUsagesCollector.php

@@ -17,7 +17,7 @@
 /**
  * @implements Collector<Node, list<string>>
  */
-class ProvidedUsagesCollector implements Collector
+final class ProvidedUsagesCollector implements Collector
 {
 
     use BufferedUsageCollector;

src/Compatibility/BackwardCompatibilityChecker.php

@@ -9,7 +9,7 @@
 use function implode;
 use function var_export;
 
-class BackwardCompatibilityChecker
+final class BackwardCompatibilityChecker
 {
 
     /**

src/Debug/DebugUsagePrinter.php

@@ -28,7 +28,7 @@
 use function strpos;
 use function substr;
 
-class DebugUsagePrinter
+final class DebugUsagePrinter
 {
 
     public const ANY_MEMBER = "\0";

src/Excluder/MixedUsageExcluder.php

@@ -6,7 +6,7 @@
 use PHPStan\Analyser\Scope;
 use ShipMonk\PHPStan\DeadCode\Graph\ClassMemberUsage;
 
-class MixedUsageExcluder implements MemberUsageExcluder
+final class MixedUsageExcluder implements MemberUsageExcluder
 {
 
     private bool $enabled;

src/Excluder/TestsUsageExcluder.php

@@ -24,7 +24,7 @@
 use function strpos;
 use const JSON_ERROR_NONE;
 
-class TestsUsageExcluder implements MemberUsageExcluder
+final class TestsUsageExcluder implements MemberUsageExcluder
 {
 
     private ReflectionProvider $reflectionProvider;

src/Formatter/RemoveDeadCodeFormatter.php

@@ -15,7 +15,7 @@
 use function array_keys;
 use function count;
 
-class RemoveDeadCodeFormatter implements ErrorFormatter
+final class RemoveDeadCodeFormatter implements ErrorFormatter
 {
 
     private FileSystem $fileSystem;

src/Hierarchy/ClassHierarchy.php

@@ -4,7 +4,7 @@
 
 use function array_keys;
 
-class ClassHierarchy
+final class ClassHierarchy
 {
 
     /**

src/Output/OutputEnhancer.php

@@ -8,7 +8,7 @@
 use function sprintf;
 use function str_replace;
 
-class OutputEnhancer
+final class OutputEnhancer
 {
 
     private RelativePathHelper $relativePathHelper;

src/Provider/ApiPhpDocUsageProvider.php

@@ -9,7 +9,7 @@
 use ShipMonk\PHPStan\DeadCode\Reflection\ReflectionHelper;
 use function strpos;
 
-class ApiPhpDocUsageProvider extends ReflectionBasedMemberUsageProvider
+final class ApiPhpDocUsageProvider extends ReflectionBasedMemberUsageProvider
 {
 
     private ReflectionProvider $reflectionProvider;

src/Provider/BuiltinUsageProvider.php

@@ -7,7 +7,7 @@
 use ReflectionMethod;
 use Reflector;
 
-class BuiltinUsageProvider extends ReflectionBasedMemberUsageProvider
+final class BuiltinUsageProvider extends ReflectionBasedMemberUsageProvider
 {
 
     private bool $enabled;

src/Provider/DoctrineUsageProvider.php

@@ -20,7 +20,7 @@
 use ShipMonk\PHPStan\DeadCode\Graph\ClassMethodUsage;
 use ShipMonk\PHPStan\DeadCode\Graph\UsageOrigin;
 
-class DoctrineUsageProvider implements MemberUsageProvider
+final class DoctrineUsageProvider implements MemberUsageProvider
 {
 
     private bool $enabled;
@@ -147,7 +147,7 @@ private function getUsagesOfEventSubscriber(
         return $usages;
     }
 
-    protected function shouldMarkMethodAsUsed(ReflectionMethod $method): ?string
+    private function shouldMarkMethodAsUsed(ReflectionMethod $method): ?string
     {
         $methodName = $method->getName();
         $class = $method->getDeclaringClass();
@@ -171,7 +171,7 @@ protected function shouldMarkMethodAsUsed(ReflectionMethod $method): ?string
         return null;
     }
 
-    protected function isLifecycleEventMethod(ReflectionMethod $method): bool
+    private function isLifecycleEventMethod(ReflectionMethod $method): bool
     {
         return $this->hasAttribute($method, 'Doctrine\ORM\Mapping\PostLoad')
             || $this->hasAttribute($method, 'Doctrine\ORM\Mapping\PostPersist')
@@ -186,7 +186,7 @@ protected function isLifecycleEventMethod(ReflectionMethod $method): bool
      * Ideally, we would need to parse DIC xml to know this for sure just like phpstan-symfony does.
      * - see Doctrine\ORM\Events::*
      */
-    protected function isProbablyDoctrineListener(string $methodName): bool
+    private function isProbablyDoctrineListener(string $methodName): bool
     {
         return $methodName === 'preRemove'
             || $methodName === 'postRemove'
@@ -203,15 +203,15 @@ protected function isProbablyDoctrineListener(string $methodName): bool
             || $methodName === 'onClear';
     }
 
-    protected function hasAttribute(
+    private function hasAttribute(
         ReflectionMethod $method,
         string $attributeClass
     ): bool
     {
         return $method->getAttributes($attributeClass) !== [];
     }
 
-    protected function isPartOfAsEntityListener(
+    private function isPartOfAsEntityListener(
         ReflectionClass $class,
         string $methodName
     ): bool
@@ -227,7 +227,7 @@ protected function isPartOfAsEntityListener(
         return false;
     }
 
-    protected function isEntityRepositoryConstructor(
+    private function isEntityRepositoryConstructor(
         ReflectionClass $class,
         ReflectionMethod $method
     ): bool

src/Provider/EnumUsageProvider.php

@@ -24,7 +24,7 @@
 use function is_int;
 use function is_string;
 
-class EnumUsageProvider implements MemberUsageProvider
+final class EnumUsageProvider implements MemberUsageProvider
 {
 
     private bool $enabled;

src/Provider/NetteUsageProvider.php

@@ -18,7 +18,7 @@
 use function ucfirst;
 use const PREG_SET_ORDER;
 
-class NetteUsageProvider extends ReflectionBasedMemberUsageProvider
+final class NetteUsageProvider extends ReflectionBasedMemberUsageProvider
 {
 
     private ReflectionProvider $reflectionProvider;

src/Provider/PhpStanUsageProvider.php

@@ -5,7 +5,7 @@
 use PHPStan\DependencyInjection\Container;
 use ReflectionMethod;
 
-class PhpStanUsageProvider extends ReflectionBasedMemberUsageProvider
+final class PhpStanUsageProvider extends ReflectionBasedMemberUsageProvider
 {
 
     private bool $enabled;

src/Provider/PhpUnitUsageProvider.php

@@ -18,7 +18,7 @@
 use function is_string;
 use function strpos;
 
-class PhpUnitUsageProvider implements MemberUsageProvider
+final class PhpUnitUsageProvider implements MemberUsageProvider
 {
 
     private bool $enabled;

src/Provider/ReflectionUsageProvider.php

@@ -23,7 +23,7 @@
 use function count;
 use function in_array;
 
-class ReflectionUsageProvider implements MemberUsageProvider
+final class ReflectionUsageProvider implements MemberUsageProvider
 {
 
     private bool $enabled;

src/Provider/SymfonyUsageProvider.php

@@ -47,7 +47,7 @@
 use function sprintf;
 use function strpos;
 
-class SymfonyUsageProvider implements MemberUsageProvider
+final class SymfonyUsageProvider implements MemberUsageProvider
 {
 
     private bool $enabled;
@@ -353,7 +353,7 @@ private function getMethodUsagesFromAttributeReflection(
         return $usages;
     }
 
-    protected function shouldMarkAsUsed(ReflectionMethod $method): ?string
+    private function shouldMarkAsUsed(ReflectionMethod $method): ?string
     {
         if ($this->isBundleConstructor($method)) {
             return 'Bundle constructor (created by Kernel)';
@@ -390,7 +390,7 @@ protected function shouldMarkAsUsed(ReflectionMethod $method): ?string
         return null;
     }
 
-    protected function fillDicClasses(string $containerXmlPath): void
+    private function fillDicClasses(string $containerXmlPath): void
     {
         $fileContents = file_get_contents($containerXmlPath);
 
@@ -480,45 +480,45 @@ private function buildXmlServiceMap(SimpleXMLElement $serviceDefinitions): array
         return $serviceMap;
     }
 
-    protected function isBundleConstructor(ReflectionMethod $method): bool
+    private function isBundleConstructor(ReflectionMethod $method): bool
     {
         return $method->isConstructor() && $method->getDeclaringClass()->isSubclassOf('Symfony\Component\HttpKernel\Bundle\Bundle');
     }
 
-    protected function isAutowiredWithRequiredAttribute(ReflectionMethod $method): bool
+    private function isAutowiredWithRequiredAttribute(ReflectionMethod $method): bool
     {
         return $this->hasAttribute($method, 'Symfony\Contracts\Service\Attribute\Required');
     }
 
-    protected function isEventListenerMethodWithAsEventListenerAttribute(ReflectionMethod $method): bool
+    private function isEventListenerMethodWithAsEventListenerAttribute(ReflectionMethod $method): bool
     {
         $class = $method->getDeclaringClass();
 
         return $this->hasAttribute($class, 'Symfony\Component\EventDispatcher\Attribute\AsEventListener')
             || $this->hasAttribute($method, 'Symfony\Component\EventDispatcher\Attribute\AsEventListener');
     }
 
-    protected function isConstructorWithAsCommandAttribute(ReflectionMethod $method): bool
+    private function isConstructorWithAsCommandAttribute(ReflectionMethod $method): bool
     {
         $class = $method->getDeclaringClass();
         return $method->isConstructor() && $this->hasAttribute($class, 'Symfony\Component\Console\Attribute\AsCommand');
     }
 
-    protected function isConstructorWithAsControllerAttribute(ReflectionMethod $method): bool
+    private function isConstructorWithAsControllerAttribute(ReflectionMethod $method): bool
     {
         $class = $method->getDeclaringClass();
         return $method->isConstructor() && $this->hasAttribute($class, 'Symfony\Component\HttpKernel\Attribute\AsController');
     }
 
-    protected function isMethodWithRouteAttribute(ReflectionMethod $method): bool
+    private function isMethodWithRouteAttribute(ReflectionMethod $method): bool
     {
         $isInstanceOf = 2; // ReflectionAttribute::IS_INSTANCEOF, since PHP 8.0
 
         return $this->hasAttribute($method, 'Symfony\Component\Routing\Attribute\Route', $isInstanceOf)
             || $this->hasAttribute($method, 'Symfony\Component\Routing\Annotation\Route', $isInstanceOf);
     }
 
-    protected function isMethodWithCallbackConstraintAttribute(ReflectionMethod $method): bool
+    private function isMethodWithCallbackConstraintAttribute(ReflectionMethod $method): bool
     {
         $attributes = $method->getDeclaringClass()->getAttributes('Symfony\Component\Validator\Constraints\Callback');
 
@@ -538,7 +538,7 @@ protected function isMethodWithCallbackConstraintAttribute(ReflectionMethod $met
     /**
      * Ideally, we would need to parse DIC xml to know this for sure just like phpstan-symfony does.
      */
-    protected function isProbablySymfonyListener(ReflectionMethod $method): bool
+    private function isProbablySymfonyListener(ReflectionMethod $method): bool
     {
         $methodName = $method->getName();
 
@@ -555,7 +555,7 @@ protected function isProbablySymfonyListener(ReflectionMethod $method): bool
      * @param ReflectionClass|ReflectionMethod $classOrMethod
      * @param ReflectionAttribute::IS_*|0 $flags
      */
-    protected function hasAttribute(
+    private function hasAttribute(
         Reflector $classOrMethod,
         string $attributeClass,
         int $flags = 0

src/Provider/TwigUsageProvider.php

@@ -21,7 +21,7 @@
 use function explode;
 use function in_array;
 
-class TwigUsageProvider implements MemberUsageProvider
+final class TwigUsageProvider implements MemberUsageProvider
 {
 
     private bool $enabled;
@@ -178,7 +178,7 @@ private function getMethodUsagesFromReflection(InClassNode $node): array
         return $usages;
     }
 
-    protected function shouldMarkAsUsed(ReflectionMethod $method): ?string
+    private function shouldMarkAsUsed(ReflectionMethod $method): ?string
     {
         if ($this->isMethodWithAsTwigFilterAttribute($method)) {
             return 'Twig filter method via #[AsTwigFilter] attribute';
@@ -195,22 +195,22 @@ protected function shouldMarkAsUsed(ReflectionMethod $method): ?string
         return null;
     }
 
-    protected function isMethodWithAsTwigFilterAttribute(ReflectionMethod $method): bool
+    private function isMethodWithAsTwigFilterAttribute(ReflectionMethod $method): bool
     {
         return $this->hasAttribute($method, 'Twig\Attribute\AsTwigFilter');
     }
 
-    protected function isMethodWithAsTwigFunctionAttribute(ReflectionMethod $method): bool
+    private function isMethodWithAsTwigFunctionAttribute(ReflectionMethod $method): bool
     {
         return $this->hasAttribute($method, 'Twig\Attribute\AsTwigFunction');
     }
 
-    protected function isMethodWithAsTwigTestAttribute(ReflectionMethod $method): bool
+    private function isMethodWithAsTwigTestAttribute(ReflectionMethod $method): bool
     {
         return $this->hasAttribute($method, 'Twig\Attribute\AsTwigTest');
     }
 
-    protected function hasAttribute(
+    private function hasAttribute(
         ReflectionMethod $method,
         string $attributeClass
     ): bool

src/Provider/VendorUsageProvider.php

@@ -12,7 +12,7 @@
 use function strpos;
 use function substr;
 
-class VendorUsageProvider extends ReflectionBasedMemberUsageProvider
+final class VendorUsageProvider extends ReflectionBasedMemberUsageProvider
 {
 
     /**

src/Rule/DeadCodeRule.php

@@ -46,7 +46,7 @@
 /**
  * @implements Rule<CollectedDataNode>
  */
-class DeadCodeRule implements Rule, DiagnoseExtension
+final class DeadCodeRule implements Rule, DiagnoseExtension
 {
 
     public const IDENTIFIER_METHOD = 'shipmonk.deadMethod';