Skip to content

RuleTestCase: improve main assert error message #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janedbal merged 4 commits into from
Dec 9, 2025
Merged

RuleTestCase: improve main assert error message #11

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2eaa920
RuleTestCase: improve main assert error message
janedbal Dec 9, 2025
5502f07
Add simple test
janedbal Dec 9, 2025
62e357f
squash tests
janedbal Dec 9, 2025
a6b5b45
Win fix
janedbal Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/RuleTestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
use function file_get_contents;
use function file_put_contents;
use function implode;
use function in_array;
use function ksort;
use function preg_match;
use function preg_match_all;
Expand Down Expand Up @@ -62,10 +63,15 @@ protected function analyzeFiles(
$actualErrors = $this->processActualErrors(array_values($fileErrors));
$expectedErrors = $this->parseExpectedErrors($file);

$extraErrors = array_filter($actualErrors, static fn (string $error): bool => !in_array($error, $expectedErrors, true));
$missingErrors = array_filter($expectedErrors, static fn (string $error): bool => !in_array($error, $actualErrors, true));

self::assertSame(
implode("\n", $expectedErrors) . "\n",
implode("\n", $actualErrors) . "\n",
"Errors in file {$file} do not match",
"Errors in file {$file} do not match:\n\n" .
($extraErrors === [] ? '' : "New errors reported:\n" . implode("\n", $extraErrors) . "\n\n") .
($missingErrors === [] ? '' : "Errors not reported:\n" . implode("\n", $missingErrors) . "\n\n"),
);
}
}
Expand Down