Skip to content

More release-plan tweaks #2877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobbieTheWagner merged 4 commits into from
Jan 14, 2026
Merged

More release-plan tweaks #2877

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a64ca4b
Keep trying to make release-plan work
RobbieTheWagner Jan 14, 2026
dc1ca9a
Copy root README
RobbieTheWagner Jan 14, 2026
95f8ee7
Update exports
RobbieTheWagner Jan 14, 2026
2ce8955
Update package.json
RobbieTheWagner Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# See http://help.github.com/ignore-files/ for more about ignoring files.

# compiled output
/dist
dist
/tmp
/out-tsc

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
},
"scripts": {
"build": "ng build",
"build_lib": "ng build shepherd",
"build_lib": "ng build shepherd && cp README.md projects/shepherd/dist/",
"e2e": "ng e2e",
"lint": "ng lint",
"ng": "ng",
Expand Down
245 changes: 0 additions & 245 deletions projects/shepherd/README.md
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion projects/shepherd/ng-package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "../../node_modules/ng-packagr/ng-package.schema.json",
"dest": "../../dist/angular-shepherd",
"dest": "dist",
Copy link

@coderabbitai coderabbitai bot Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

cat projects/shepherd/ng-package.json

Repository: shipshapecode/angular-shepherd

Length of output: 295

🏁 Script executed:

cat package.json | jq '.scripts.npm_pack' 2>/dev/null || cat package.json | grep -A 5 '"npm_pack"'

Repository: shipshapecode/angular-shepherd

Length of output: 112

Fix misaligned output path in npm_pack script.

The dest in projects/shepherd/ng-package.json is now "dist" (resolving to projects/shepherd/dist/), but the root package.json npm_pack script still references cd dist/angular-shepherd. This mismatch will break the package script when it tries to locate the compiled output.

Update the npm_pack script to use the correct path that aligns with the new destination.

🤖 Prompt for AI Agents 
In `@projects/shepherd/ng-package.json` at line 3, The npm_pack script in the root
package.json references the old output path "cd dist/angular-shepherd" which no
longer matches the ng-package.json dest set to "dist" (outputting to
projects/shepherd/dist/); update the npm_pack script to cd into the new compiled
folder (adjust the path to projects/shepherd/dist/angular-shepherd or if the
package is now directly under projects/shepherd/dist, change to cd
projects/shepherd/dist) and ensure subsequent tar or npm pack commands target
that corrected directory so the package script can find the build output.

"lib": {
"entryFile": "src/public_api.ts"
},
Expand Down
6 changes: 4 additions & 2 deletions projects/shepherd/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,11 @@
"@angular/core": "^21.0.0"
},
"publishConfig": {
"registry": "https://registry.npmjs.org",
"directory": "../../dist/angular-shepherd"
"registry": "https://registry.npmjs.org"
},
"files": [
"dist"
],
"release-plan": {
"tagFormat": "v${version}"
}
Expand Down
Loading