Skip to content

Conversation

@madebydavid
Copy link
Contributor

@madebydavid madebydavid commented Jan 6, 2026

Goal

This is to resolve #128 - to summarize as a story:

As a user of shipthis I would like to be warned, and able to fix my configuration, if it is set to use the legacy build mode (and I therefore would not be able to upload the resulting binary to Google Play).

What's changed

  • Replacing the godot export preset and project.godot parsing functions with our own npm lib https://github.com/shipth-is/godot-export-presets
  • Detecting if gradle is enabled in the Create Initial Build
  • Detecting if we have an AAB file specifically when deciding if we should make initial build in the wizard
  • Showing a warning markdown file to ask user if they are happy with the change
  • Added function to make change to export preset file
  • Added warning shown below the progress bar on shipthis game ship
  • Fixed the colours of the output when running shipthis game ship --follow

Demo

Warning in the android wizard

Screen recording below - you should see the prompt at 1min 05sec - I pressed Y to change the setting and continue

wizard-showing-prompt.webm

Warning when running ship command

image

Warning when running ship command with --follow

image

To test

  • shipthis game create - Uses getGodotProjectName(), getGodotVersion(), isCWDGodotGame()
    • Test in a Godot project directory
    • Verify project name detection
    • Verify version detection
  • shipthis game ios app create - Uses getGodotAppleBundleIdentifier()
    • Test with/without export_presets.cfg
    • Verify bundle identifier detection
  • shipthis game android wizard - Uses getGodotAndroidPackageName(), getGodotVersion()
    • Test with/without export_presets.cfg
    • Verify package name detection
  • shipthis game ios wizard - Uses getGodotProjectCapabilities()
    • Test with export_presets.cfg containing capabilities
    • Verify capability detection
  • shipthis status - Uses isCWDGodotGame()
    • Test in Godot and non-Godot directories
  • shipthis game ios app sync - used in the wizard but also reads the capabilities
  • shipthis game ship
  • shipthis game ship --follow

@madebydavid
Copy link
Contributor Author

Performing testing of other related commands - this should be ready to be reviewed shortly.

@madebydavid madebydavid changed the title WIP: feature: warning users when their export_presets.cfg is set to "legacy" build mode feature: warning users when their export_presets.cfg is set to "legacy" build mode Jan 8, 2026
@madebydavid madebydavid marked this pull request as ready for review January 8, 2026 18:38
@madebydavid madebydavid requested a review from jamiel January 8, 2026 18:38
@madebydavid madebydavid merged commit 6376cff into main Jan 9, 2026
@madebydavid madebydavid deleted the 128-feature-warning-users-when-their-export_presetscfg-is-set-to-legacy-build-mode branch January 9, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature: warning users when their export_presets.cfg is set to "legacy" build mode

3 participants