Omit leading slash when extracting entrypoint binary#2139
Open
SaschaSchwarze0 wants to merge 1 commit intomainfrom
Open
Omit leading slash when extracting entrypoint binary#2139SaschaSchwarze0 wants to merge 1 commit intomainfrom
SaschaSchwarze0 wants to merge 1 commit intomainfrom
Conversation
Signed-off-by: Sascha Schwarze <schwarzs@de.ibm.com>
pull-request-size
bot
added
the
size/XS
openshift-ci
bot
added
the
release-note-none
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
gcr v0.21.3 changed the format of the tarball produced by
crane export. Entries now do not start anymore with a slash (which is kind of recommended for tarballs).This PR adapts the scripts we have that call
crane exportwhen scanning for release vulnerabilities by removing the leading slash of the entrypoint binary when extracting it from the tarball.The action was failing since this run. I tested my changes in that run.
Type of PR
/kind bug
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes