Ship 0039/261 - add --scheduler-name flag

[rxinui]

Changes

Fixes #261

Add CLI flag --scheduler-name to set .spec.schedulerName to a Build or BuildRun

❗ IMPORTANT: depends on my other PR 309 as v1beta1 is required (and inherently to PR 304)

Submitter Checklist

• Includes tests if functionality changed/was added
• Includes docs if changes are user-facing
• Set a kind label on this PR
• Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Add flag --scheduler-name to set the `.spec.schedulerName` for `build` and `buildrun` on create and run

[rxinui]

/status in-review

[openshift-ci]

@rxinui: The label(s) kind/enhancement cannot be applied, because the repository doesn't have them.

Details

In response to this:

/kind enhancement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[rxinui]

@adambkaplan Now that #260 is merged, this is now rebased on main.

[adambkaplan]

/approve

Only notable issues seem related to rebasing. Otherwise the code looks good!

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [adambkaplan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rxinui]

@adambkaplan all good now.

On a side note, I'll move back to neovim (or zed).

[rxinui]

e2e tests are not ending. None of them are related to my PRs - mine are OK. That is weird. Have you encountered that before?

[rxinui]

@SaschaSchwarze0 i have applied your suggestions. Tests are still OK on my changes yet the bats test on --follow-logs seem to be faulty.

[rxinui]

@SaschaSchwarze0 i gave another try to Sanitize method. It seems to solve the problem although one test is now faulty.

This is due to the suggestion you made which is

run kubectl get buildruns.shipwright.io -l build.shipwright.io/name=${build_name} -ojsonpath='{.spec.schedulerName}'

There is not output with this get command. I haven't debugged locally yet but perhaps I would assume you did not take into consideration the jsonpath. I think it might required to be -ojsonpath='{.items[*].spec.schedulerName}'

[SaschaSchwarze0]

/lgtm