Dependency updates for the v0.17 release #342
Conversation
SaschaSchwarze0
force-pushed
the
sascha-updates
branch
4 times, most recently
from
9316b04 to
f434f60
Compare
Signed-off-by: Sascha Schwarze <[email protected]>
Signed-off-by: Sascha Schwarze <[email protected]>
SaschaSchwarze0
force-pushed
the
sascha-updates
branch
from
f434f60 to
e417e53
Compare
adambkaplan
left a comment
adambkaplan
left a comment
There was a problem hiding this comment.
/approve
Just a few questions related to the non-CI/vendor changes. I don't see these explained in the commit message.
| - v1.31.9 | ||
| - v1.33.1 |
There was a problem hiding this comment.
Point this out (not blocking): we may want to update the test matrix to keep the min k8s/Tekton and latest k8s/Tekton versions in sync. See https://github.com/shipwright-io/build/blob/main/.github/workflows/ci.yml#L79-L85
| assert_success | ||
| refute_line --regexp "GET .*/apis/shipwright.io/v1beta1/namespaces/" | ||
| refute_line --partial "Response Headers" | ||
| refute_line --partial "Request Body" |
There was a problem hiding this comment.
Did k8s update cause this to change/break?
| } | ||
|
|
||
| // ExecuteWithContext implements exec.RemoteExecutor. | ||
| func (f *FakeRemoteExecutor) ExecuteWithContext(_ context.Context, url *url.URL, config *rest.Config, stdin io.Reader, stdout io.Writer, stderr io.Writer, tty bool, terminalSizeQueue remotecommand.TerminalSizeQueue) error { |
There was a problem hiding this comment.
Was this related to the k8s bump?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
approved
| // Executor is the name and kind of the resource responsible for executing this BuildRun. | ||
| // | ||
| // +optional | ||
| Executor *BuildExecutor `json:"executor,omitempty"` |
There was a problem hiding this comment.
Follow-up item: should we add this to any CLI outputs?
github-project-automation
bot
moved this from In Progress
to Done
in Shipwright Overview
2 participants
Changes
Fixes #336
This updates go.mod and GitHub actions for the next release.
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes