Fix buildrun list command #343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Changes: - Check if BuildSpec exists in Status of BuildRun, since it an optional field in the API - Try to get SourceOrigin from BuildRunSpec if it doesn't exist in BuildRun status. Signed-off-by: Sayan Biswas <[email protected]>
pull-request-size
bot
added
the
size/S
Member
|
/kind bug |
adambkaplan
approved these changes
Sep 2, 2025
Member
adambkaplan
left a comment
adambkaplan
left a comment
There was a problem hiding this comment.
/approve
/lgtm
A good fix to squeeze into the v0.17.0 release.
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 1a95935
into
shipwright-io:main
11 of 12 checks passed
github-project-automation
bot
moved this from In Progress
to Done
in Shipwright Overview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #339
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes